Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Arnd Bergmann <arnd@arndb.de>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3] net: gemini: Clean up phy registration
Date: Sun, 6 Sep 2020 12:28:29 -0700	[thread overview]
Message-ID: <20200906122829.4a8503bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200906192113.53801-1-linus.walleij@linaro.org>

On Sun,  6 Sep 2020 21:21:13 +0200 Linus Walleij wrote:
> It's nice if the phy is online before we register the netdev
> so try to do that first.
> 
> Stop trying to do "second tried" to register the phy, it
> works perfectly fine the first time.
> 
> Stop remvoving the phy in uninit. Remove it when the
> driver is remove():d, symmetric to where it is added, in
> probe().
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reported-by: David Miller <davem@davemloft.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v2->v3:
> - Fix a goto on the errorpath noticed by Jakub.
> ChangeLog v1->v2:
> - Do a deeper clean-up and remove the confusion around
>   how the phy is registered.

Applied, thanks!

      reply	other threads:[~2020-09-06 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 19:21 [PATCH v3] net: gemini: Clean up phy registration Linus Walleij
2020-09-06 19:28 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906122829.4a8503bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).