Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config
Date: Sun, 6 Sep 2020 12:34:51 -0700	[thread overview]
Message-ID: <20200906123451.4ab26ee5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CACRpkdYyaQtptvaTUieEsSyHCB+PYHvgmzNfvhuaJ-Lc9dreFA@mail.gmail.com>

On Sun, 6 Sep 2020 21:23:37 +0200 Linus Walleij wrote:
> On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Sat,  5 Sep 2020 12:32:33 +0200 Linus Walleij wrote:  
> > > When removing a port from a VLAN we are just erasing the
> > > member config for the VLAN, which is wrong: other ports
> > > can be using it.
> > >
> > > Just mask off the port and only zero out the rest of the
> > > member config once ports using of the VLAN are removed
> > > from it.
> > >
> > > Reported-by: Florian Fainelli <f.fainelli@gmail.com>
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>  
> >
> > I see you labeled this for net-net, but it reads like a fix, is it not?
> >
> > Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> >
> > Like commit 15ab7906cc92 ("net: dsa: rtl8366: Fix VLAN semantics") had?  
> 
> Yes you're right, also it is pretty separate from the other patches to
> this driver so there shouldn't be any annoying conflicts.
> 
> If you're applying the patch could you add it
> in the process, or do you want me to resend?

Done & applied to net, thank you!

      reply	other threads:[~2020-09-06 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 10:32 [net-next PATCH] net: dsa: rtl8366: Properly clear member config Linus Walleij
2020-09-06 17:40 ` Jakub Kicinski
2020-09-06 19:23   ` Linus Walleij
2020-09-06 19:34     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906123451.4ab26ee5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).