From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B55C43461 for ; Sun, 6 Sep 2020 19:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E08882080A for ; Sun, 6 Sep 2020 19:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599420895; bh=kNSWg5ml9f8BCpyLU0jDgp5KmkbvgDfUFDHlg08Zsz0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=zSSUWMJt8O5M1GJDam6r/TEW0XBaE+nUQXiPeieB0LM82blIPz+UcXOcxREDYHhaS Irz9K1wvrx4RlTHWF95lo2omHYqxWtevFkS7tvxbLfDAWEVnUPBVc04HdMvIvyblFu Ixt4YrAYpcA7GtCqiRIds/AoaoCF1Fwjp8pZm9M4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgIFTey (ORCPT ); Sun, 6 Sep 2020 15:34:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:49226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgIFTex (ORCPT ); Sun, 6 Sep 2020 15:34:53 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B83A2080A; Sun, 6 Sep 2020 19:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599420893; bh=kNSWg5ml9f8BCpyLU0jDgp5KmkbvgDfUFDHlg08Zsz0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LqiPNfGBYmqfucaPza5XGNssrMi7hALx4S0fQzQ22egLBmZSg0hPSem9RLC1iQQ9m j8BxJ4UsXI7e9PLUP6pk4HfBS9P24MSW9G00lvFgF2RBMaQCOSRlkjiqhUcobGhlCd 1XdmGxWJNt9TDnl655PPn+K1XvdLp2aSTB2tRgq4= Date: Sun, 6 Sep 2020 12:34:51 -0700 From: Jakub Kicinski To: Linus Walleij Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , netdev , "David S . Miller" Subject: Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config Message-ID: <20200906123451.4ab26ee5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200905103233.16922-1-linus.walleij@linaro.org> <20200906104058.1b0ac9bc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 6 Sep 2020 21:23:37 +0200 Linus Walleij wrote: > On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski wrote: > > On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > > > When removing a port from a VLAN we are just erasing the > > > member config for the VLAN, which is wrong: other ports > > > can be using it. > > > > > > Just mask off the port and only zero out the rest of the > > > member config once ports using of the VLAN are removed > > > from it. > > > > > > Reported-by: Florian Fainelli > > > Signed-off-by: Linus Walleij > > > > I see you labeled this for net-net, but it reads like a fix, is it not? > > > > Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") > > > > Like commit 15ab7906cc92 ("net: dsa: rtl8366: Fix VLAN semantics") had? > > Yes you're right, also it is pretty separate from the other patches to > this driver so there shouldn't be any annoying conflicts. > > If you're applying the patch could you add it > in the process, or do you want me to resend? Done & applied to net, thank you!