From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7F5C43461 for ; Sun, 6 Sep 2020 14:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E67FB20714 for ; Sun, 6 Sep 2020 14:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbgIFOnG (ORCPT ); Sun, 6 Sep 2020 10:43:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45598 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728902AbgIFOkI (ORCPT ); Sun, 6 Sep 2020 10:40:08 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kEvpZ-00DUNC-GQ; Sun, 06 Sep 2020 16:39:45 +0200 Date: Sun, 6 Sep 2020 16:39:45 +0200 From: Andrew Lunn To: Linus Walleij Cc: netdev@vger.kernel.org, "David S . Miller" , Hans Ulli Kroll Subject: Re: [net-next PATCH v2] net: gemini: Clean up phy registration Message-ID: <20200906143945.GL3164319@lunn.ch> References: <20200905204257.51044-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200905204257.51044-1-linus.walleij@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Sep 05, 2020 at 10:42:57PM +0200, Linus Walleij wrote: > It's nice if the phy is online before we register the netdev > so try to do that first. > > Stop trying to do "second tried" to register the phy, it > works perfectly fine the first time. > > Stop remvoving the phy in uninit. Remove it when the > driver is remove():d, symmetric to where it is added, in > probe(). > > Suggested-by: Andrew Lunn > Reported-by: David Miller > Signed-off-by: Linus Walleij Reviewed-by: Andrew Lunn Andrew