Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
	Networking <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket
Date: Mon, 7 Sep 2020 09:58:13 -0700	[thread overview]
Message-ID: <20200907095813.4cdacb5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <378cfa5a-eb06-d04c-bbbc-07b377f60c11@kernel.dk>

On Mon, 7 Sep 2020 10:45:00 -0600 Jens Axboe wrote:
> On 9/6/20 11:48 PM, Christoph Hellwig wrote:
> > On Sat, Sep 05, 2020 at 04:05:48PM -0600, Jens Axboe wrote:  
> >> There's a trivial io_uring patch that depends on this one. If this one
> >> is acceptable to you, I'd like to queue it up in the io_uring branch for
> >> 5.10.  
> > 
> > Can you give it a better name?  These __ names re just horrible.
> > sock_shutdown_sock?  
> 
> Sure, I don't really care, just following what is mostly done already. And
> it is meant to be internal in the sense that it's not exported to modules.
> 
> I'll let the net guys pass the final judgement on that, I'm obviously fine
> with anything in terms of naming :-)

So am I :) But if Christoph prefers sock_shutdown_sock() let's use that.

  reply	other threads:[~2020-09-07 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 22:05 Jens Axboe
2020-09-05 22:39 ` Jakub Kicinski
2020-09-05 22:51   ` Jens Axboe
2020-09-07  5:48 ` Christoph Hellwig
2020-09-07 16:45   ` Jens Axboe
2020-09-07 16:58     ` Jakub Kicinski [this message]
2020-09-07 17:00       ` Christoph Hellwig
2020-09-07 19:32         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907095813.4cdacb5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH for-next] net: provide __sys_shutdown_sock() that takes a socket' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).