Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Hoang Huu Le <hoang.h.le@dektech.com.au>
Cc: ying.xue@windriver.com, netdev@vger.kernel.org,
jmaloy@redhat.com, maloy@donjonn.com,
syzbot+d5aa7e0385f6a5d0f4fd@syzkaller.appspotmail.com
Subject: Re: [net-next v2] tipc: fix a deadlock when flushing scheduled work
Date: Mon, 7 Sep 2020 12:10:14 -0700 [thread overview]
Message-ID: <20200907121014.033a183c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200907060007.43750-1-hoang.h.le@dektech.com.au>
On Mon, 7 Sep 2020 13:00:07 +0700 Hoang Huu Le wrote:
> In the commit fdeba99b1e58
> ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying
> to make sure the tipc_net_finalize_work work item finished if it
> enqueued. But calling flush_scheduled_work() is not just affecting
> above work item but either any scheduled work. This has turned out
> to be overkill and caused to deadlock as syzbot reported:
Applied, thanks.
next prev parent reply other threads:[~2020-09-07 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 6:00 [net-next v2] tipc: fix a deadlock when flushing scheduled work Hoang Huu Le
2020-09-07 19:10 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-05 4:45 [net-next] " Hoang Huu Le
2020-09-07 6:17 ` [net-next v2] " Hoang Huu Le
2020-09-07 15:05 ` Xue, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907121014.033a183c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=hoang.h.le@dektech.com.au \
--cc=jmaloy@redhat.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+d5aa7e0385f6a5d0f4fd@syzkaller.appspotmail.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).