Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'
@ 2020-09-07 14:12 Wang Hai
2020-09-07 20:58 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-09-07 14:12 UTC (permalink / raw)
To: davem, kuba, f.fainelli, timur, zhengdejin5, hkallweit1, leon
Cc: netdev, linux-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/dnet.c: In function dnet_start_xmit
drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)")
involved this unused variable, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/dnet.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c
index db98274501a0..3143df9a398c 100644
--- a/drivers/net/ethernet/dnet.c
+++ b/drivers/net/ethernet/dnet.c
@@ -508,7 +508,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
struct dnet *bp = netdev_priv(dev);
u32 tx_status, irq_enable;
- unsigned int len, i, tx_cmd, wrsz;
+ unsigned int i, tx_cmd, wrsz;
unsigned long flags;
unsigned int *bufp;
@@ -518,9 +518,6 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb->len, skb->head, skb->data);
dnet_print_skb(skb);
- /* frame size (words) */
- len = (skb->len + 3) >> 2;
-
spin_lock_irqsave(&bp->lock, flags);
tx_status = dnet_readl(bp, TX_STATUS);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'
2020-09-07 14:12 [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len' Wang Hai
@ 2020-09-07 20:58 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-09-07 20:58 UTC (permalink / raw)
To: Wang Hai
Cc: davem, f.fainelli, timur, zhengdejin5, hkallweit1, leon, netdev,
linux-kernel
On Mon, 7 Sep 2020 22:12:07 +0800 Wang Hai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/dnet.c: In function dnet_start_xmit
> drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
>
> commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)")
> involved this unused variable, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
tx_status is also not used. But I guess one change per commit,
so applied. Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 14:12 [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len' Wang Hai
2020-09-07 20:58 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).