Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nathan Chancellor <natechancellor@gmail.com>
To: trix@redhat.com
Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
ndesaulniers@google.com, mkenna@codeaurora.org,
vnaralas@codeaurora.org, rmanohar@codeaurora.org,
john@phrozen.org, ath11k@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] ath11k: fix a double free and a memory leak
Date: Mon, 7 Sep 2020 21:26:01 -0700 [thread overview]
Message-ID: <20200908042601.GB111690@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <20200906212625.17059-1-trix@redhat.com>
On Sun, Sep 06, 2020 at 02:26:25PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analyzer reports this problem
>
> mac.c:6204:2: warning: Attempt to free released memory
> kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The channels pointer is allocated in ath11k_mac_setup_channels_rates()
> When it fails midway, it cleans up the memory it has already allocated.
> So the error handling needs to skip freeing the memory.
>
> There is a second problem.
> ath11k_mac_setup_channels_rates(), allocates 3 channels. err_free
> misses releasing ar->mac.sbands[NL80211_BAND_6GHZ].channels
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/net/wireless/ath/ath11k/mac.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index f4a085baff38..f1a964b01a83 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -6089,7 +6089,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
> ret = ath11k_mac_setup_channels_rates(ar,
> cap->supported_bands);
> if (ret)
> - goto err_free;
> + goto err;
>
> ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
> ath11k_mac_setup_he_cap(ar, cap);
> @@ -6203,7 +6203,8 @@ static int __ath11k_mac_register(struct ath11k *ar)
> err_free:
> kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels);
> kfree(ar->mac.sbands[NL80211_BAND_5GHZ].channels);
> -
> + kfree(ar->mac.sbands[NL80211_BAND_6GHZ].channels);
> +err:
> SET_IEEE80211_DEV(ar->hw, NULL);
> return ret;
> }
> --
> 2.18.1
>
next prev parent reply other threads:[~2020-09-08 4:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 21:26 [PATCH] ath11k: fix a double free and a memory leak trix
2020-09-08 4:26 ` Nathan Chancellor [this message]
2020-09-08 5:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908042601.GB111690@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkenna@codeaurora.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=trix@redhat.com \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).