Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Parav Pandit <parav@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v2 5/6] devlink: Introduce controller number
Date: Tue, 8 Sep 2020 11:50:06 -0700 [thread overview]
Message-ID: <20200908115006.3b9ba943@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200908144241.21673-6-parav@mellanox.com>
On Tue, 8 Sep 2020 17:42:40 +0300 Parav Pandit wrote:
> A devlink port may be for a controller consist of PCI device.
Humm?
> A devlink instance holds ports of two types of controllers.
> (1) controller discovered on same system where eswitch resides
> This is the case where PCI PF/VF of a controller and devlink eswitch
> instance both are located on a single system.
> (2) controller located on external host system.
> This is the case where a controller is located in one system and its
> devlink eswitch ports are located in a different system.
>
> When a devlink eswitch instance serves the devlink ports of both
> controllers together, PCI PF/VF numbers may overlap.
> Due to this a unique phys_port_name cannot be constructed.
>
> For example in below such system controller-A and controller-B, each has
> PCI PF pf0 whose eswitch ports are present in controller-A.
> These results in phys_port_name as "pf0" for both.
> Similar problem exists for VFs and upcoming Sub functions.
>
> An example view of two controller systems:
>
> -----------------------------------------------------
> | |
> | --------- --------- |
> ------------- | | vf(s) | | sf(s) | |
> | server | | ------- ----/---- ---/----- ------- |
> | pci rc |=====| pf0 |______/________/ | pf1 | |
> | connection| | ------- ------- |
> ------------- | | controller-B (no eswitch) (controller num=1)|
> ------|----------------------------------------------
> (internal wire)
> |
> -----------------------------------------------------
> | devlink eswitch ports and reps |
> | --------------------------------------------- |
> | |ctrl-A | ctrl-B | ctrl-A | ctrl-B | ctrl-B | |
> | |pf0 | pf0 | pf0vfN | pf0vfN | pf0sfN | |
> | --------------------------------------------- |
^^^^^^^^
ctrl-A doesn't have VFs, but sfs below.
pf1 reprs are not listed.
Perhaps it'd be clearer if controllers where not interleaved?
> | |
> | --------- |
> | | sf(s) | |
> | ------- ---/----- ------- |
> | | pf0 |_____/ | pf1 | |
> | ------- ------- |
> | |
> | local controller-A (eswitch) (controller num=0) |
> -----------------------------------------------------
next prev parent reply other threads:[~2020-09-08 18:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:58 [PATCH net-next 0/3] devlink show controller info Parav Pandit
2020-08-25 13:58 ` [PATCH net-next 1/3] devlink: Add comment block for missing port attributes Parav Pandit
2020-08-25 13:58 ` [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name Parav Pandit
2020-08-26 0:32 ` Jakub Kicinski
2020-08-26 4:27 ` Parav Pandit
2020-08-26 20:07 ` Jakub Kicinski
2020-08-27 4:31 ` Parav Pandit
2020-08-27 18:32 ` Jakub Kicinski
2020-08-27 20:15 ` Parav Pandit
2020-08-27 21:42 ` Jakub Kicinski
2020-08-28 4:27 ` Parav Pandit
2020-08-28 5:08 ` Parav Pandit
2020-08-28 16:43 ` Jakub Kicinski
2020-08-29 3:43 ` Parav Pandit
2020-09-01 8:19 ` Jiri Pirko
2020-09-01 8:53 ` Parav Pandit
2020-09-01 9:17 ` Jiri Pirko
2020-09-01 21:28 ` Jakub Kicinski
2020-09-02 4:26 ` Parav Pandit
2020-09-02 4:44 ` Parav Pandit
2020-09-02 8:00 ` Jiri Pirko
2020-09-02 15:23 ` Jakub Kicinski
2020-09-02 16:18 ` Parav Pandit
2020-09-02 20:10 ` Parav Pandit
2020-09-03 5:54 ` Jiri Pirko
2020-09-03 19:31 ` Jakub Kicinski
2020-09-04 8:43 ` Jiri Pirko
2020-09-06 3:08 ` Parav Pandit
2020-09-06 16:46 ` Jakub Kicinski
2020-09-07 7:21 ` Jiri Pirko
2020-09-07 16:18 ` Jakub Kicinski
2020-08-25 13:58 ` [PATCH net-next 3/3] net/mlx5: E-switch, Set controller attribute for PCI PF and VF ports Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 0/6] devlink show controller number Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 1/6] net/mlx5: E-switch, Read controller number from device Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 2/6] devlink: Add comment block for missing port attributes Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 3/6] devlink: Move structure comments outside of structure Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 4/6] devlink: Introduce external controller flag Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 5/6] devlink: Introduce controller number Parav Pandit
2020-09-08 18:50 ` Jakub Kicinski [this message]
2020-09-09 3:06 ` Parav Pandit
2020-09-08 14:42 ` [PATCH net-next v2 6/6] devlink: Use controller while building phys_port_name Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 0/6] devlink show controller number Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 1/6] net/mlx5: E-switch, Read controller number from device Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 2/6] devlink: Add comment block for missing port attributes Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 3/6] devlink: Move structure comments outside of structure Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 4/6] devlink: Introduce external controller flag Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 5/6] devlink: Introduce controller number Parav Pandit
2020-09-09 4:50 ` [PATCH net-next v3 6/6] devlink: Use controller while building phys_port_name Parav Pandit
2020-09-10 15:02 ` David Ahern
2020-09-09 15:34 ` [PATCH net-next v3 0/6] devlink show controller number Jakub Kicinski
2020-09-09 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908115006.3b9ba943@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).