Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection
Date: Thu, 10 Sep 2020 20:09:00 +0200	[thread overview]
Message-ID: <20200910180900.GE3354160@lunn.ch> (raw)
In-Reply-To: <aea8db25-88a9-d8d2-1a26-ecb81dbeb2b5@ti.com>

> The note in the ethtool.h says
> 
>     /* Last allowed bit for __ETHTOOL_LINK_MODE_LEGACY_MASK is bit
>      * 31. Please do NOT define any SUPPORTED_* or ADVERTISED_*
>      * macro for bits > 31. The only way to use indices > 31 is to
>      * use the new ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API.
>      */
> 
> Which was added by Heiner
> 
> I guess I would prefer to add this in a separate patchset once I figure out
> how the ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API works

The phydev supported value is no longer a u32, it is now a bitmap. So
you can do something like

linkmode_set_bit(ETHTOOL_LINK_MODE_100BaseFX_Full_BIT, &supported);

       Andrew

  reply	other threads:[~2020-09-10 18:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 11:42 [PATCH net-next v3 0/3] DP83869 Feature additions Dan Murphy
2020-09-03 11:42 ` [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection Dan Murphy
2020-09-05 18:17   ` Jakub Kicinski
2020-09-07 14:29     ` Andrew Lunn
2020-09-10 17:54       ` Dan Murphy
2020-09-10 18:09         ` Andrew Lunn [this message]
2020-09-03 11:42 ` [PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN Dan Murphy
2020-09-05 18:34   ` Jakub Kicinski
2020-09-10 17:34     ` Dan Murphy
2020-09-10 18:02       ` Andrew Lunn
2020-09-10 18:21         ` Dan Murphy
2020-09-03 11:42 ` [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature Dan Murphy
2020-09-05 18:38   ` Jakub Kicinski
2020-09-08 14:07     ` Dan Murphy
2020-09-08 17:47       ` Jakub Kicinski
2020-09-10 17:34         ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910180900.GE3354160@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dmurphy@ti.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).