From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2E2C43463 for ; Mon, 21 Sep 2020 02:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05417207BB for ; Mon, 21 Sep 2020 02:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbgIUCCL (ORCPT ); Sun, 20 Sep 2020 22:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgIUCCL (ORCPT ); Sun, 20 Sep 2020 22:02:11 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9ABDC061755 for ; Sun, 20 Sep 2020 19:02:10 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AC6C413D6D6DA; Sun, 20 Sep 2020 18:45:19 -0700 (PDT) Date: Sun, 20 Sep 2020 19:02:04 -0700 (PDT) Message-Id: <20200920.190204.372392542090417415.davem@davemloft.net> To: vladimir.oltean@nxp.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, idosch@idosch.org, jiri@resnulli.us, kurt.kanzenbach@linutronix.de, kuba@kernel.org Subject: Re: [PATCH v2 net-next 0/9] DSA with VLAN filtering and offloading masters From: David Miller In-Reply-To: <20200921001031.3650456-1-vladimir.oltean@nxp.com> References: <20200921001031.3650456-1-vladimir.oltean@nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sun, 20 Sep 2020 18:45:20 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Date: Mon, 21 Sep 2020 03:10:22 +0300 > This series attempts to make DSA VLANs work in the presence of a master > interface that is: > - filtering, so it drops VLANs that aren't explicitly added to its > filter list > - offloading, so the old assumptions in the tagging code about there > being a VLAN tag in the skb are not necessarily true anymore. > > For more context: > https://lore.kernel.org/netdev/20200910150738.mwhh2i6j2qgacqev@skbuf/ > > This probably marks the beginning of a series of patches in which DSA > starts paying much more attention to its upper interfaces, not only for > VLAN purposes but also for address filtering and for management of the > CPU flooding domain. There was a comment from Florian on whether we > could factor some of the mlxsw logic into some common functionality, but > it doesn't look so. This seems bound to be open-coded, but frankly there > isn't a lot to it. > > Changes in v2: > Applied Florian's cosmetic suggestion in patch 4/9. Series applied, thanks.