Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Thomas Falcon <tlfalcon@linux.ibm.com>,
netdev@vger.kernel.org, jiri@nvidia.com
Subject: Re: Exposing device ACL setting through devlink
Date: Mon, 21 Sep 2020 13:37:04 -0700 [thread overview]
Message-ID: <20200921133704.5ad64b6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200920152136.GB2323@nanopsycho.orion>
On Sun, 20 Sep 2020 17:21:36 +0200 Jiri Pirko wrote:
> >Yes, this the filtering is done on a virtual switch in Power firmware. I am
> >really just trying to report the ACL list's configured at the firmware level
> >to users on the guest OS.
>
> We have means to model switches properly in linux and offload to them.
> I advise you to do that.
I think it may have gotten lost in the conversation, but Tom is after
exposing the information to the client side of the switch. AFAIU we
don't have anything like that right now, perhaps the way to go is to
expose enum devlink_port_function_attr on the client side?
Still - it feels hacky when I think about it.
IMHO kernel device APIs are not the place to expose network config.
It's not like MVRP results pop up as a netdev attribute.
Tomorrow Amazon, Google, and all other cloud providers will want to
expose some other info, and we'll have to worry about how to make it
common, drawing the lines, reviewing etc.
Tom, is there no way higher layer (cloud) APIs can be used to
communicate this information to the guest?
next prev parent reply other threads:[~2020-09-21 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 17:59 Thomas Falcon
2020-09-04 8:31 ` Jiri Pirko
2020-09-04 22:37 ` Jakub Kicinski
2020-09-08 18:27 ` Thomas Falcon
2020-09-10 7:00 ` Jiri Pirko
2020-09-17 20:31 ` Thomas Falcon
2020-09-18 7:20 ` Jiri Pirko
2020-09-18 23:20 ` Thomas Falcon
2020-09-20 15:21 ` Jiri Pirko
2020-09-21 17:51 ` Thomas Falcon
2020-09-21 20:37 ` Jakub Kicinski [this message]
2020-09-23 17:01 ` Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921133704.5ad64b6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
--subject='Re: Exposing device ACL setting through devlink' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).