Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, roopa@nvidia.com, davem@davemloft.net,
	bridge@lists.linux-foundation.org,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	Marek Lindner <mareklindner@neomailbox.ch>,
	Simon Wunderlich <sw@simonwunderlich.de>,
	Sven Eckelmann <sven@narfation.org>,
	b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH net-next 06/16] net: bridge: mcast: rename br_ip's u member to dst
Date: Mon, 21 Sep 2020 21:30:18 +0800	[thread overview]
Message-ID: <202009212146.1IVUIG6Z%lkp@intel.com> (raw)
In-Reply-To: <20200921105526.1056983-7-razor@blackwall.org>

[-- Attachment #1: Type: text/plain, Size: 3695 bytes --]

Hi Nikolay,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-IGMPv3-MLDv2-fast-path-part-2/20200921-185933
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3cec0369905d086a56a7515f3449982403057599
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/batman-adv/multicast.c: In function 'batadv_mcast_mla_br_addr_cpy':
>> net/batman-adv/multicast.c:564:20: error: 'const struct br_ip' has no member named 'u'
     564 |   ip_eth_mc_map(src->u.ip4, dst);
         |                    ^~
   net/batman-adv/multicast.c:567:23: error: 'const struct br_ip' has no member named 'u'
     567 |   ipv6_eth_mc_map(&src->u.ip6, dst);
         |                       ^~

# https://github.com/0day-ci/linux/commit/195fb98d13499e5a7c5a2a750e6a7e0cbcfaccdc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nikolay-Aleksandrov/net-bridge-mcast-IGMPv3-MLDv2-fast-path-part-2/20200921-185933
git checkout 195fb98d13499e5a7c5a2a750e6a7e0cbcfaccdc
vim +564 net/batman-adv/multicast.c

c5caf4ef34e277 Linus Lüssing  2014-02-15  548  
687937ab34896d Linus Lüssing  2016-05-10  549  /**
7e9a8c2ce7c5f8 Sven Eckelmann 2017-12-02  550   * batadv_mcast_mla_br_addr_cpy() - copy a bridge multicast address
687937ab34896d Linus Lüssing  2016-05-10  551   * @dst: destination to write to - a multicast MAC address
687937ab34896d Linus Lüssing  2016-05-10  552   * @src: source to read from - a multicast IP address
687937ab34896d Linus Lüssing  2016-05-10  553   *
687937ab34896d Linus Lüssing  2016-05-10  554   * Converts a given multicast IPv4/IPv6 address from a bridge
687937ab34896d Linus Lüssing  2016-05-10  555   * to its matching multicast MAC address and copies it into the given
687937ab34896d Linus Lüssing  2016-05-10  556   * destination buffer.
687937ab34896d Linus Lüssing  2016-05-10  557   *
687937ab34896d Linus Lüssing  2016-05-10  558   * Caller needs to make sure the destination buffer can hold
687937ab34896d Linus Lüssing  2016-05-10  559   * at least ETH_ALEN bytes.
687937ab34896d Linus Lüssing  2016-05-10  560   */
687937ab34896d Linus Lüssing  2016-05-10  561  static void batadv_mcast_mla_br_addr_cpy(char *dst, const struct br_ip *src)
687937ab34896d Linus Lüssing  2016-05-10  562  {
687937ab34896d Linus Lüssing  2016-05-10  563  	if (src->proto == htons(ETH_P_IP))
687937ab34896d Linus Lüssing  2016-05-10 @564  		ip_eth_mc_map(src->u.ip4, dst);
687937ab34896d Linus Lüssing  2016-05-10  565  #if IS_ENABLED(CONFIG_IPV6)
687937ab34896d Linus Lüssing  2016-05-10  566  	else if (src->proto == htons(ETH_P_IPV6))
687937ab34896d Linus Lüssing  2016-05-10  567  		ipv6_eth_mc_map(&src->u.ip6, dst);
687937ab34896d Linus Lüssing  2016-05-10  568  #endif
687937ab34896d Linus Lüssing  2016-05-10  569  	else
687937ab34896d Linus Lüssing  2016-05-10  570  		eth_zero_addr(dst);
687937ab34896d Linus Lüssing  2016-05-10  571  }
687937ab34896d Linus Lüssing  2016-05-10  572  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66214 bytes --]

  reply	other threads:[~2020-09-21 13:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 10:55 [PATCH net-next 00/16] net: bridge: mcast: IGMPv3/MLDv2 fast-path (part 2) Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 01/16] net: bridge: mdb: use extack in br_mdb_parse() Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 02/16] net: bridge: mdb: move all port and bridge checks to br_mdb_add Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 03/16] net: bridge: mdb: use extack in br_mdb_add() and br_mdb_add_group() Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 04/16] net: bridge: add src field to br_ip Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 05/16] net: bridge: mcast: use br_ip's src for src groups and querier address Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 06/16] net: bridge: mcast: rename br_ip's u member to dst Nikolay Aleksandrov
2020-09-21 13:30   ` kernel test robot [this message]
2020-09-21 13:33     ` Nikolay Aleksandrov
2020-09-21 20:49   ` kernel test robot
2020-09-21 10:55 ` [PATCH net-next 07/16] net: bridge: mdb: add support to extend add/del commands Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 08/16] net: bridge: mdb: add support for add/del/dump of entries with source Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 09/16] net: bridge: mcast: when igmpv3/mldv2 are enabled lookup (S,G) first, then (*,G) Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 10/16] net: bridge: mcast: add rt_protocol field to the port group struct Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 11/16] net: bridge: mcast: add sg_port rhashtable Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 12/16] net: bridge: mcast: install S,G entries automatically based on reports Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 13/16] net: bridge: mcast: handle port group filter modes Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 14/16] net: bridge: mcast: add support for blocked port groups Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 15/16] net: bridge: mcast: handle host state Nikolay Aleksandrov
2020-09-21 10:55 ` [PATCH net-next 16/16] net: bridge: mcast: when forwarding handle filter mode and blocked flag Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202009212146.1IVUIG6Z%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=sven@narfation.org \
    --cc=sw@simonwunderlich.de \
    --subject='Re: [PATCH net-next 06/16] net: bridge: mcast: rename br_ip'\''s u member to dst' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).