Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Saeed Mahameed <saeed@kernel.org>
Cc: eranbe@mellanox.com, lariel@mellanox.com, saeedm@mellanox.com,
leon@kernel.org, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: remove unreachable return
Date: Tue, 22 Sep 2020 22:05:24 +0200 [thread overview]
Message-ID: <20200922200524.GA4975@duo.ucw.cz> (raw)
In-Reply-To: <4eb581435bd7ac528c29815a7d26016bd1c429f4.camel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
On Tue 2020-09-22 12:54:20, Saeed Mahameed wrote:
> On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote:
> > On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote:
> > > The last return statement is unreachable code. I'm not sure if it
> > > will
> > > provoke any warnings, but it looks ugly.
> > >
> > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> > >
> > >
> >
> > Applied to net-next-mlx5.
> >
> > Thanks,
> > Saeed.
> >
>
> Actually checkpatch reports this issue:
> WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal
> patch author 'Pavel Machek <pavel@ucw.cz>'
>
> Do you want me to override the Signed-off-by tag with the above email ?
Sorry about that.
Actually, overriding patch author to match signoff would be better (I
should have sent it from: denx), but either way is okay with me.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2020-09-22 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 11:41 Pavel Machek
2020-09-22 5:54 ` Saeed Mahameed
2020-09-22 19:54 ` Saeed Mahameed
2020-09-22 20:05 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922200524.GA4975@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=kuba@kernel.org \
--cc=lariel@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@mellanox.com \
--subject='Re: [PATCH] net/mlx5: remove unreachable return' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).