Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] brcmfmac: check return value of driver_for_each_device()
@ 2020-09-19 2:06 Zhang Changzhong
2020-09-24 15:48 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-09-19 2:06 UTC (permalink / raw)
To: kvalo, davem, kuba; +Cc: linux-wireless, netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
variable 'ret' set but not used [-Wunused-but-set-variable]
1576 | int ret;
| ^~~
driver_for_each_device() has been declared with __must_check, so the
return value should be checked.
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
v2:
- cc linux-wireless
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index ac54638..6f67fef 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -1578,6 +1578,9 @@ void brcmf_usb_exit(void)
brcmf_dbg(USB, "Enter\n");
ret = driver_for_each_device(drv, NULL, NULL,
brcmf_usb_reset_device);
+ if (ret)
+ brcmf_err("failed to reset all usb devices %d\n", ret);
+
usb_deregister(&brcmf_usbdrvr);
}
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] brcmfmac: check return value of driver_for_each_device()
2020-09-19 2:06 [PATCH v2] brcmfmac: check return value of driver_for_each_device() Zhang Changzhong
@ 2020-09-24 15:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-09-24 15:48 UTC (permalink / raw)
To: Zhang Changzhong; +Cc: davem, kuba, linux-wireless, netdev, linux-kernel
Zhang Changzhong <zhangchangzhong@huawei.com> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
> variable 'ret' set but not used [-Wunused-but-set-variable]
> 1576 | int ret;
> | ^~~
>
> driver_for_each_device() has been declared with __must_check, so the
> return value should be checked.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
72a398a63b88 brcmfmac: check return value of driver_for_each_device()
--
https://patchwork.kernel.org/patch/11786561/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-24 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 2:06 [PATCH v2] brcmfmac: check return value of driver_for_each_device() Zhang Changzhong
2020-09-24 15:48 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).