From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6A7C11F76 for ; Tue, 6 Jul 2021 12:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41DA66230A for ; Tue, 6 Jul 2021 12:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233379AbhGFM0l (ORCPT ); Tue, 6 Jul 2021 08:26:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:47570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232518AbhGFLhB (ORCPT ); Tue, 6 Jul 2021 07:37:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05DAD61F4B; Tue, 6 Jul 2021 11:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625570978; bh=n8HH0ifXpBfgFOKff9LgCjq0R3YigGwqXA0aKClj30o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C8U/ZlkFSebjxTX2bOafaKsCVtr8pghsaPdLXhPaye5vd1N1C1PR4MZkwjKov6/dj eouqGrsXZc3/4OCSE/AUljOH8PUmXfJXyM+B/jvcS1MECbJhEi7ymmUi0ihS9fuvfU g6nQ75+sJpQnOt9QlmJP6X+Busb5BZdVEcy3vyThRNJQKYdls0qJgajC3UmVs1oqz4 gx2Zmaqfc8AJklVnU1l0ufKO4QSWmrEnfNIasVfxJCWF8OafmByJ1BYpi7SsynXtrD up7+lYfCAy6CW5Y4ljI9/5XlIP2UUezY4cgBPIzVofoSoUiemkSp8Pv2AnObBCdCfU H1fohn2Ln5YRQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zou Wei , Hulk Robot , "David S . Miller" , Sasha Levin , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/31] atm: nicstar: Fix possible use-after-free in nicstar_cleanup() Date: Tue, 6 Jul 2021 07:29:05 -0400 Message-Id: <20210706112931.2066397-5-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706112931.2066397-1-sashal@kernel.org> References: <20210706112931.2066397-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zou Wei [ Upstream commit 34e7434ba4e97f4b85c1423a59b2922ba7dff2ea ] This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Zou Wei Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/nicstar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 49da83f87170..486d7a114031 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -298,7 +298,7 @@ static void __exit nicstar_cleanup(void) { XPRINTK("nicstar: nicstar_cleanup() called.\n"); - del_timer(&ns_timer); + del_timer_sync(&ns_timer); pci_unregister_driver(&nicstar_driver); -- 2.30.2