Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Guangbin Huang <huangguangbin2@huawei.com>
Cc: <davem@davemloft.net>, <jiri@nvidia.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [PATCH net-next 1/9] devlink: add documentation for hns3 driver
Date: Mon, 12 Jul 2021 11:32:43 -0700	[thread overview]
Message-ID: <20210712113243.2d786fe3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1626053698-46849-2-git-send-email-huangguangbin2@huawei.com>

On Mon, 12 Jul 2021 09:34:50 +0800 Guangbin Huang wrote:
> +Parameters
> +==========
> +
> +The ``hns3`` driver implements the following driver-specific
> +parameters.
> +
> +.. list-table:: Driver-specific parameters implemented
> +   :widths: 10 10 10 70
> +
> +   * - Name
> +     - Type
> +     - Mode
> +     - Description
> +   * - ``rx_buf_len``
> +     - U32
> +     - driverinit
> +     - Set rx BD buffer size.
> +       * Now only support setting 2048 and 4096.

Can you elaborate further? If I was a user reading this I'd still have
little confidence what this does. Does it change the size of each
buffer put on the Rx ring between 2k and 4k? Why is that a devlink
feature, we configure rings via ethtool.

> +   * - ``tx_buf_size``
> +     - U32
> +     - driverinit
> +     - Set tx spare buf size.
> +
> +       * The size is setted for tx bounce feature.

... and what is the tx bounce feature?

  reply	other threads:[~2021-07-12 18:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  1:34 [PATCH net-next 0/9] net: hns3: add support devlink Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 1/9] devlink: add documentation for hns3 driver Guangbin Huang
2021-07-12 18:32   ` Jakub Kicinski [this message]
2021-07-13 12:34     ` huangguangbin (A)
2021-07-12  1:34 ` [PATCH net-next 2/9] net: hns3: add support for registering devlink for PF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 3/9] net: hns3: add support for registering devlink for VF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 4/9] net: hns3: add support for devlink get info for PF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 5/9] net: hns3: add support for devlink get info for VF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 6/9] net: hns3: add devlink reload support for PF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 7/9] net: hns3: add devlink reload support for VF Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 8/9] net: hns3: add support for PF setting rx/tx buffer size by devlink param Guangbin Huang
2021-07-12  1:34 ` [PATCH net-next 9/9] net: hns3: add support for VF " Guangbin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210712113243.2d786fe3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=huangguangbin2@huawei.com \
    --cc=jiri@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 1/9] devlink: add documentation for hns3 driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).