Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: <alexandru.tachici@analog.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Cc: <robh+dt@kernel.org>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
	<linux@armlinux.org.uk>, <davem@davemloft.net>, <kuba@kernel.org>,
	"Alexandru Tachici" <alexandru.tachici@analog.com>
Subject: [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support
Date: Mon, 12 Jul 2021 16:06:28 +0300	[thread overview]
Message-ID: <20210712130631.38153-5-alexandru.tachici@analog.com> (raw)
In-Reply-To: <20210712130631.38153-1-alexandru.tachici@analog.com>

From: Alexandru Tachici <alexandru.tachici@analog.com>

The PHY has multiple error counters and one frame counter.
This change enables the frame checker and allows ethtool
to retrieve the counters values.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
 drivers/net/phy/adin1100.c | 79 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/drivers/net/phy/adin1100.c b/drivers/net/phy/adin1100.c
index 682fc617c51b..94deaf52bbcd 100644
--- a/drivers/net/phy/adin1100.c
+++ b/drivers/net/phy/adin1100.c
@@ -57,6 +57,8 @@ static const int phy_10_features_array[] = {
 #define   ADIN_AN_LP_ADV_B10L_TX_LVL_HI_REQ	BIT(12)
 #define   ADIN_AN_LP_ADV_B10S_HD		BIT(11)
 
+#define ADIN_FC_EN				0x8001
+
 #define ADIN_CRSM_SFT_RST			0x8810
 #define   ADIN_CRSM_SFT_RST_EN			BIT(0)
 
@@ -71,11 +73,32 @@ static const int phy_10_features_array[] = {
 #define   ADIN_MAC_IF_LOOPBACK_EN		BIT(0)
 #define   ADIN_MAC_IF_REMOTE_LOOPBACK_EN	BIT(2)
 
+struct adin_hw_stat {
+	const char *string;
+	u16 reg1;
+	u16 reg2;
+};
+
+static const struct adin_hw_stat adin_hw_stats[] = {
+	{ "total_frames_error_count",		0x8008 },
+	{ "total_frames_count",			0x8009, 0x800A }, /* hi, lo */
+	{ "length_error_frames_count",		0x800B },
+	{ "alignment_error_frames_count",	0x800C },
+	{ "symbol_error_count",			0x800D },
+	{ "oversized_frames_count",		0x800E },
+	{ "undersized_frames_count",		0x800F },
+	{ "odd_nibble_frames_count",		0x8010 },
+	{ "odd_preamble_packet_count",		0x8011 },
+	{ "false_carrier_events_count",		0x8013 },
+};
+
 /**
  * struct adin_priv - ADIN PHY driver private data
  * tx_level_24v			set if the PHY supports 2.4V TX levels (10BASE-T1L)
+ * stats:			statistic counters for the PHY
  */
 struct adin_priv {
+	u64			stats[ARRAY_SIZE(adin_hw_stats)];
 	unsigned int		tx_level_24v:1;
 };
 
@@ -249,6 +272,11 @@ static int adin_soft_reset(struct phy_device *phydev)
 					 10000, 30000, true);
 }
 
+static int adin_config_init(struct phy_device *phydev)
+{
+	return phy_write_mmd(phydev, MDIO_MMD_VEND2, ADIN_FC_EN, 1);
+}
+
 static int adin_get_features(struct phy_device *phydev)
 {
 	struct adin_priv *priv = phydev->priv;
@@ -285,6 +313,53 @@ static int adin_get_features(struct phy_device *phydev)
 	return 0;
 }
 
+static int adin_get_sset_count(struct phy_device *phydev)
+{
+	return ARRAY_SIZE(adin_hw_stats);
+}
+
+static void adin_get_strings(struct phy_device *phydev, u8 *data)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(adin_hw_stats); i++)
+		strscpy(&data[i * ETH_GSTRING_LEN], adin_hw_stats[i].string, ETH_GSTRING_LEN);
+}
+
+static u64 adin_get_stat(struct phy_device *phydev, int i)
+{
+	const struct adin_hw_stat *stat = &adin_hw_stats[i];
+	struct adin_priv *priv = phydev->priv;
+	u64 val;
+	int ret;
+
+	ret = phy_read_mmd(phydev, MDIO_MMD_VEND2, stat->reg1);
+	if (ret < 0)
+		return U64_MAX;
+
+	val = (0xffff & ret);
+
+	if (stat->reg2 != 0) {
+		ret = phy_read_mmd(phydev, MDIO_MMD_VEND2, stat->reg2);
+		if (ret < 0)
+			return U64_MAX;
+
+		val = (val << 16) + (0xffff & ret);
+	}
+
+	priv->stats[i] += val;
+
+	return priv->stats[i];
+}
+
+static void adin_get_stats(struct phy_device *phydev, struct ethtool_stats *stats, u64 *data)
+{
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(adin_hw_stats); i++)
+		data[i] = adin_get_stat(phydev, i);
+}
+
 static int adin_probe(struct phy_device *phydev)
 {
 	struct device *dev = &phydev->mdio.dev;
@@ -306,11 +381,15 @@ static struct phy_driver adin_driver[] = {
 		.get_features		= adin_get_features,
 		.soft_reset		= adin_soft_reset,
 		.probe			= adin_probe,
+		.config_init		= adin_config_init,
 		.config_aneg		= adin_config_aneg,
 		.read_status		= adin_read_status,
 		.set_loopback		= adin_set_loopback,
 		.suspend		= adin_suspend,
 		.resume			= adin_resume,
+		.get_sset_count		= adin_get_sset_count,
+		.get_strings		= adin_get_strings,
+		.get_stats		= adin_get_stats,
 	},
 };
 
-- 
2.25.1


  parent reply	other threads:[~2021-07-12 12:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 13:06 [PATCH v2 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-07-12 13:06 ` [PATCH v2 1/7] ethtool: Add 10base-T1L link mode entries alexandru.tachici
2021-07-13 16:50   ` Andrew Lunn
2021-07-27  5:56   ` Oleksij Rempel
2021-07-12 13:06 ` [PATCH v2 2/7] ethtool: Add 10base-T1L voltage levels " alexandru.tachici
2021-07-12 13:06 ` [PATCH v2 3/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY alexandru.tachici
2021-07-13 16:58   ` Andrew Lunn
2021-07-16 21:24     ` ADIN1100 alexandru.tachici
2021-07-23 17:20       ` ADIN1100 Oleksij Rempel
2021-07-27  6:31     ` [PATCH v2 3/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY Oleksij Rempel
2021-07-27  6:47   ` Oleksij Rempel
2021-07-27 16:36     ` Andrew Lunn
2021-07-12 13:06 ` alexandru.tachici [this message]
2021-07-12 18:41   ` [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support Jakub Kicinski
2021-07-12 13:06 ` [PATCH v2 5/7] net: phy: adin1100: Add ethtool master-slave support alexandru.tachici
2021-07-13 17:53   ` Andrew Lunn
2021-07-12 13:06 ` [PATCH v2 6/7] net: phy: adin1100: Add SQI support alexandru.tachici
2021-07-13 17:55   ` Andrew Lunn
2021-07-12 13:06 ` [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY alexandru.tachici
2021-07-12 14:12   ` Rob Herring
2021-07-12 17:46     ` Rob Herring
2021-07-27  5:53   ` Oleksij Rempel
2021-07-28 17:23     ` Rob Herring
2021-07-29  5:02       ` Oleksij Rempel
2021-07-12 13:33 ` [PATCH v2 0/7] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY Russell King (Oracle)
2021-07-23 17:32   ` Oleksij Rempel
2021-08-03  9:47     ` alexandru.tachici
2021-08-03 11:59       ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210712130631.38153-5-alexandru.tachici@analog.com \
    --to=alexandru.tachici@analog.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v2 4/7] net: phy: adin1100: Add ethtool get_stats support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).