Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* DSA .port_{f,m}db_{add,del} with offloaded LAG interface on mv88e6xxx
@ 2021-07-19 12:22 DENG Qingfang
  2021-07-19 12:45 ` Vladimir Oltean
  0 siblings, 1 reply; 2+ messages in thread
From: DENG Qingfang @ 2021-07-19 12:22 UTC (permalink / raw)
  To: netdev
  Cc: Vladimir Oltean, Andrew Lunn, Marek Behún,
	Tobias Waldekranz, Vivien Didelot,
	Russell King - ARM Linux admin, Florian Fainelli

Hi,

What happens if a FDB entry is added manually to an offloaded LAG
interface? Does DSA core simply call .port_fdb_add with the member
ports in the LAG?

I'm asking because there is a trunk field in struct
mv88e6xxx_atu_entry, when it is true, the portvec is actually the
trunk ID.
As the current implementation (mv88e6xxx_port_db_load_purge) does not
use this field, it probably won't work.

Regards,
Qingfang

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: DSA .port_{f,m}db_{add,del} with offloaded LAG interface on mv88e6xxx
  2021-07-19 12:22 DSA .port_{f,m}db_{add,del} with offloaded LAG interface on mv88e6xxx DENG Qingfang
@ 2021-07-19 12:45 ` Vladimir Oltean
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Oltean @ 2021-07-19 12:45 UTC (permalink / raw)
  To: DENG Qingfang
  Cc: netdev, Andrew Lunn, Marek Behún, Tobias Waldekranz,
	Vivien Didelot, Russell King - ARM Linux admin, Florian Fainelli

Hi Qingfang,

On Mon, Jul 19, 2021 at 08:22:01PM +0800, DENG Qingfang wrote:
> Hi,
> 
> What happens if a FDB entry is added manually to an offloaded LAG
> interface? Does DSA core simply call .port_fdb_add with the member
> ports in the LAG?
> 
> I'm asking because there is a trunk field in struct
> mv88e6xxx_atu_entry, when it is true, the portvec is actually the
> trunk ID.
> As the current implementation (mv88e6xxx_port_db_load_purge) does not
> use this field, it probably won't work.
> 
> Regards,
> Qingfang

This is not supported at the moment.
Coincidentally or not, I am currently working on refactoring the DSA
handler for SWITCHDEV_FDB_ADD_TO_DEVICE to remove some of the technical
debt (in particular, local FDB entries pointing towards the bridge do
not work in all situations when combined with FDB replays). One of the
extra features of the new implementation will be a new .lag_fdb_add()
method in struct dsa_switch_ops.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-19 12:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 12:22 DSA .port_{f,m}db_{add,del} with offloaded LAG interface on mv88e6xxx DENG Qingfang
2021-07-19 12:45 ` Vladimir Oltean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).