Netdev Archive on
help / color / mirror / Atom feed
From: Pavel Skripkin <>
To: Andre Naujoks <>
Cc: Wolfgang Grandegger <>,
	Marc Kleine-Budde <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	Stephane Grosjean <>,
	Vincent Mailhol <>,
	"Gustavo A. R. Silva" <>,
	Colin Ian King <>,,,
Subject: Re: [PATCH] Expose Peak USB device id in sysfs via phys_port_name.
Date: Wed, 21 Jul 2021 15:52:40 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 21 Jul 2021 14:40:47 +0200
Andre Naujoks <> wrote:

> The Peak USB CAN adapters can be assigned a device id via the Peak
> provided tools (pcan-settings). This id can currently not be set by
> the upstream kernel drivers, but some devices expose this id already.
> The id can be used for consistent naming of CAN interfaces regardless
> of order of attachment or recognition on the system. The classical
> CAN Peak USB adapters expose this id via bcdDevice (combined with
> another value) on USB-level in the sysfs tree and this value is then
> available in ID_REVISION from udev. This is not a feasible approach,
> when a single USB device offers more than one CAN-interface, like
> e.g. the PCAN-USB Pro FD devices.
> This patch exposes those ids via the, up to now unused, netdevice
> sysfs attribute phys_port_name as a simple decimal ASCII
> representation of the id. phys_port_id was not used, since the
> default print functions from net/core/net-sysfs.c output a
> hex-encoded binary value, which is overkill for a one-byte device id,
> like this one.

Hi, Andre!

You should add Signed-off-by tag to the patch

With regards,
Pavel Skripkin

  reply	other threads:[~2021-07-21 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 12:40 Andre Naujoks
2021-07-21 12:52 ` Pavel Skripkin [this message]
2021-07-21 12:59 ` [PATCH v2] " Andre Naujoks
2021-07-21 13:29   ` Stéphane Grosjean
2021-07-21 13:39     ` Andre Naujoks
     [not found]       ` <>
2021-07-23  7:33         ` Andre Naujoks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Expose Peak USB device id in sysfs via phys_port_name.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).