Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too
@ 2021-07-22 13:05 Vladimir Oltean
  2021-07-23 16:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2021-07-22 13:05 UTC (permalink / raw)
  To: netdev, Jakub Kicinski, David S. Miller
  Cc: Andrew Lunn, Florian Fainelli, Vivien Didelot, Eldar Gasanov

The blamed commit modified the driver to accept the addition of VID 0
without doing anything, but deleting that VID still fails:

[   32.080780] mv88e6085 d0032004.mdio-mii:10 lan8: failed to kill vid 0081/0

Modify mv88e6xxx_port_vlan_leave() to do the same thing as the addition.

Fixes: b8b79c414eca ("net: dsa: mv88e6xxx: Fix adding vlan 0")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 061271480e8a..448dcfb0955f 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -2176,7 +2176,7 @@ static int mv88e6xxx_port_vlan_leave(struct mv88e6xxx_chip *chip,
 	int i, err;
 
 	if (!vid)
-		return -EOPNOTSUPP;
+		return 0;
 
 	err = mv88e6xxx_vtu_get(chip, vid, &vlan);
 	if (err)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too
  2021-07-22 13:05 [PATCH net] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too Vladimir Oltean
@ 2021-07-23 16:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-23 16:20 UTC (permalink / raw)
  To: Vladimir Oltean
  Cc: netdev, kuba, davem, andrew, f.fainelli, vivien.didelot, eldargasanov2

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 22 Jul 2021 16:05:51 +0300 you wrote:
> The blamed commit modified the driver to accept the addition of VID 0
> without doing anything, but deleting that VID still fails:
> 
> [   32.080780] mv88e6085 d0032004.mdio-mii:10 lan8: failed to kill vid 0081/0
> 
> Modify mv88e6xxx_port_vlan_leave() to do the same thing as the addition.
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too
    https://git.kernel.org/netdev/net/c/c92c74131a84

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-23 16:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 13:05 [PATCH net] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too Vladimir Oltean
2021-07-23 16:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).