Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: build failure in Linus' tree
@ 2021-07-14 23:50 Stephen Rothwell
  2021-07-20  6:45 ` Stephen Rothwell
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2021-07-14 23:50 UTC (permalink / raw)
  To: David S. Miller
  Cc: Bjarni Jonasson, Lars Povlsen, Steen Hegelund,
	Linux Kernel Mailing List, Linux Next Mailing List, Networking

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

Hi all,

While compiling Linus' tree, a powerpc-allmodconfig build (and others)
with gcc 4.9 failed like this:

drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c: In function 'ifh_encode_bitfield':
include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_431' declared with attribute error: Unsupported width, must be <= 40
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                      ^
include/linux/compiler_types.h:309:4: note: in definition of macro '__compiletime_assert'
    prefix ## suffix();    \
    ^
include/linux/compiler_types.h:328:2: note: in expansion of macro '_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
  ^
drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c:28:2: note: in expansion of macro 'compiletime_assert'
  compiletime_assert(width <= 40, "Unsupported width, must be <= 40");
  ^

Caused by commit

  f3cad2611a77 ("net: sparx5: add hostmode with phylink support")

I guess this is caused by the call to ifh_encode_bitfield() not being
inlined.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2021-07-14 23:50 linux-next: build failure in Linus' tree Stephen Rothwell
@ 2021-07-20  6:45 ` Stephen Rothwell
  2021-07-20 12:11   ` Jakub Kicinski
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2021-07-20  6:45 UTC (permalink / raw)
  To: David S. Miller
  Cc: Bjarni Jonasson, Lars Povlsen, Steen Hegelund,
	Linux Kernel Mailing List, Linux Next Mailing List, Networking

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

Hi all,

On Thu, 15 Jul 2021 09:50:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> While compiling Linus' tree, a powerpc-allmodconfig build (and others)
> with gcc 4.9 failed like this:
> 
> drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c: In function 'ifh_encode_bitfield':
> include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_431' declared with attribute error: Unsupported width, must be <= 40
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> include/linux/compiler_types.h:309:4: note: in definition of macro '__compiletime_assert'
>     prefix ## suffix();    \
>     ^
> include/linux/compiler_types.h:328:2: note: in expansion of macro '_compiletime_assert'
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^
> drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c:28:2: note: in expansion of macro 'compiletime_assert'
>   compiletime_assert(width <= 40, "Unsupported width, must be <= 40");
>   ^
> 
> Caused by commit
> 
>   f3cad2611a77 ("net: sparx5: add hostmode with phylink support")
> 
> I guess this is caused by the call to ifh_encode_bitfield() not being
> inlined.

I am still getting these failures.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2021-07-20  6:45 ` Stephen Rothwell
@ 2021-07-20 12:11   ` Jakub Kicinski
  2021-07-22 23:04     ` Stephen Rothwell
  0 siblings, 1 reply; 8+ messages in thread
From: Jakub Kicinski @ 2021-07-20 12:11 UTC (permalink / raw)
  To: Stephen Rothwell, Bjarni Jonasson, Steen Hegelund
  Cc: David S. Miller, Lars Povlsen, Linux Kernel Mailing List,
	Linux Next Mailing List, Networking

On Tue, 20 Jul 2021 16:45:31 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 15 Jul 2021 09:50:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > While compiling Linus' tree, a powerpc-allmodconfig build (and others)
> > with gcc 4.9 failed like this:
> > 
> > drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c: In function 'ifh_encode_bitfield':
> > include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_431' declared with attribute error: Unsupported width, must be <= 40
> >   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> >                                       ^
> > include/linux/compiler_types.h:309:4: note: in definition of macro '__compiletime_assert'
> >     prefix ## suffix();    \
> >     ^
> > include/linux/compiler_types.h:328:2: note: in expansion of macro '_compiletime_assert'
> >   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> >   ^
> > drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c:28:2: note: in expansion of macro 'compiletime_assert'
> >   compiletime_assert(width <= 40, "Unsupported width, must be <= 40");
> >   ^
> > 
> > Caused by commit
> > 
> >   f3cad2611a77 ("net: sparx5: add hostmode with phylink support")
> > 
> > I guess this is caused by the call to ifh_encode_bitfield() not being
> > inlined.  
> 
> I am still getting these failures.

Bjarni, Steen, could you address this build failure ASAP?

We can't have a compile time asserts in static functions, if the code
is optimized for size chances are the function won't get inlined. clang
is pretty bad at propagating constants to compile time asserts, too.
Please remove this check, or refactor it to be done in a macro, or ..

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2021-07-20 12:11   ` Jakub Kicinski
@ 2021-07-22 23:04     ` Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2021-07-22 23:04 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Bjarni Jonasson, Steen Hegelund, David S. Miller, Lars Povlsen,
	Linux Kernel Mailing List, Linux Next Mailing List, Networking

[-- Attachment #1: Type: text/plain, Size: 1994 bytes --]

Hi all,

On Tue, 20 Jul 2021 14:11:01 +0200 Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 20 Jul 2021 16:45:31 +1000, Stephen Rothwell wrote:
> > 
> > On Thu, 15 Jul 2021 09:50:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > While compiling Linus' tree, a powerpc-allmodconfig build (and others)
> > > with gcc 4.9 failed like this:
> > > 
> > > drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c: In function 'ifh_encode_bitfield':
> > > include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_431' declared with attribute error: Unsupported width, must be <= 40
> > >   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > >                                       ^
> > > include/linux/compiler_types.h:309:4: note: in definition of macro '__compiletime_assert'
> > >     prefix ## suffix();    \
> > >     ^
> > > include/linux/compiler_types.h:328:2: note: in expansion of macro '_compiletime_assert'
> > >   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > >   ^
> > > drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c:28:2: note: in expansion of macro 'compiletime_assert'
> > >   compiletime_assert(width <= 40, "Unsupported width, must be <= 40");
> > >   ^
> > > 
> > > Caused by commit
> > > 
> > >   f3cad2611a77 ("net: sparx5: add hostmode with phylink support")
> > > 
> > > I guess this is caused by the call to ifh_encode_bitfield() not being
> > > inlined.    
> > 
> > I am still getting these failures.  
> 
> Bjarni, Steen, could you address this build failure ASAP?
> 
> We can't have a compile time asserts in static functions, if the code
> is optimized for size chances are the function won't get inlined. clang
> is pretty bad at propagating constants to compile time asserts, too.
> Please remove this check, or refactor it to be done in a macro, or ..

I am still getting these failures.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2018-06-12  2:26 Stephen Rothwell
@ 2018-06-18  3:50 ` Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2018-06-18  3:50 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Miller,
	Networking, Michael Ellerman, Benjamin Herrenschmidt, PowerPC

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Hi all,

On Tue, 12 Jun 2018 12:26:40 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Building Linus' tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> ld: net/bpfilter/bpfilter_umh.o: compiled for a little endian system and target is big endian
> ld: failed to merge target specific data of file net/bpfilter/bpfilter_umh.o
> 
> This has come to light since I started using a native compiler (i.e. one
> that can build executables, not just the kernel) for my PowerPC builds
> on a powerpcle host.
> 
> I have switched back to my limited compiler.

Any progress on this?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: build failure in Linus' tree
@ 2018-06-12  2:26 Stephen Rothwell
  2018-06-18  3:50 ` Stephen Rothwell
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2018-06-12  2:26 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Miller,
	Networking, Michael Ellerman, Benjamin Herrenschmidt, PowerPC

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (powerpc allyesconfig)
failed like this:

ld: net/bpfilter/bpfilter_umh.o: compiled for a little endian system and target is big endian
ld: failed to merge target specific data of file net/bpfilter/bpfilter_umh.o

This has come to light since I started using a native compiler (i.e. one
that can build executables, not just the kernel) for my PowerPC builds
on a powerpcle host.

I have switched back to my limited compiler.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2014-11-03  4:09 Stephen Rothwell
@ 2014-11-03  4:16 ` David Miller
  0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2014-11-03  4:16 UTC (permalink / raw)
  To: sfr; +Cc: torvalds, netdev, linux-next, linux-kernel, pablo

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Nov 2014 15:09:30 +1100

> Hi Linus,
> 
> With Linus' tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> net/bridge/netfilter/nft_reject_bridge.c: In function 'nft_reject_br_send_v6_unreach':
> net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>    csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr,
>    ^
> 
> Caused by commit 523b929d5446 ("netfilter: nft_reject_bridge: don't use
> IP stack to reject traffic") from Linus' tree.
> 
> I applied the following patch for today:

Yep, another person hit this today and submitted a patch too:

http://patchwork.ozlabs.org/patch/406003/

I'll get this into the net tree ASAP.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* linux-next: build failure in Linus' tree
@ 2014-11-03  4:09 Stephen Rothwell
  2014-11-03  4:16 ` David Miller
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Rothwell @ 2014-11-03  4:09 UTC (permalink / raw)
  To: Linus Torvalds, David Miller, netdev
  Cc: linux-next, linux-kernel, Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Hi Linus,

With Linus' tree, today's linux-next build (powerpc allyesconfig)
failed like this:

net/bridge/netfilter/nft_reject_bridge.c: In function 'nft_reject_br_send_v6_unreach':
net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr,
   ^

Caused by commit 523b929d5446 ("netfilter: nft_reject_bridge: don't use
IP stack to reject traffic") from Linus' tree.

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Nov 2014 15:01:16 +1100
Subject: [PATCH] netfilter: nft_reject_bridge: include ip6_checksum.h for csum_ipv6_magic

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/bridge/netfilter/nft_reject_bridge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bridge/netfilter/nft_reject_bridge.c b/net/bridge/netfilter/nft_reject_bridge.c
index 654c9018e3e7..1123f2b4a1b1 100644
--- a/net/bridge/netfilter/nft_reject_bridge.c
+++ b/net/bridge/netfilter/nft_reject_bridge.c
@@ -16,6 +16,7 @@
 #include <net/netfilter/nft_reject.h>
 #include <net/netfilter/ipv4/nf_reject.h>
 #include <net/netfilter/ipv6/nf_reject.h>
+#include <net/ip6_checksum.h>
 #include <linux/ip.h>
 #include <net/ip.h>
 #include <linux/netfilter_bridge.h>
-- 
2.1.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-22 23:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 23:50 linux-next: build failure in Linus' tree Stephen Rothwell
2021-07-20  6:45 ` Stephen Rothwell
2021-07-20 12:11   ` Jakub Kicinski
2021-07-22 23:04     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2018-06-12  2:26 Stephen Rothwell
2018-06-18  3:50 ` Stephen Rothwell
2014-11-03  4:09 Stephen Rothwell
2014-11-03  4:16 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).