Netdev Archive on
help / color / mirror / Atom feed
From: Tony Nguyen <>
Cc: Arkadiusz Kubalewski <>,,,,
	Aleksandr Loktionov <>,
	Imam Hassan Reza Biswas <>
Subject: [PATCH net 2/5] i40e: Fix firmware LLDP agent related warning
Date: Fri, 23 Jul 2021 10:10:20 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Arkadiusz Kubalewski <>

Make warning meaningful for the user.

Previously the trace:
"Starting FW LLDP agent failed: error: I40E_ERR_ADMIN_QUEUE_ERROR, I40E_AQ_RC_EAGAIN"
was produced when user tried to start Firmware LLDP agent,
just after it was stopped with sequence:
ethtool --set-priv-flags <dev> disable-fw-lldp on
ethtool --set-priv-flags <dev> disable-fw-lldp off
(without any delay between the commands)
At that point the firmware is still processing stop command, the behavior
is expected.

Fixes: c1041d070437 ("i40e: Missing response checks in driver when starting/stopping FW LLDP")
Signed-off-by: Aleksandr Loktionov <>
Signed-off-by: Arkadiusz Kubalewski <>
Tested-by: Imam Hassan Reza Biswas <>
Signed-off-by: Tony Nguyen <>
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 3e822bad4851..d9e26f9713a5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -5294,6 +5294,10 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)
 						 "Device configuration forbids SW from starting the LLDP agent.\n");
 					return -EINVAL;
+				case I40E_AQ_RC_EAGAIN:
+					dev_warn(&pf->pdev->dev,
+						 "Stop FW LLDP agent command is still being processed, please try again in a second.\n");
+					return -EBUSY;
 						 "Starting FW LLDP agent failed: error: %s, %s\n",

  parent reply	other threads:[~2021-07-23 17:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 17:10 [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 Tony Nguyen
2021-07-23 17:10 ` [PATCH net 1/5] i40e: Fix logic of disabling queues Tony Nguyen
2021-07-23 17:10 ` Tony Nguyen [this message]
2021-07-23 17:10 ` [PATCH net 3/5] i40e: Add additional info to PHY type error Tony Nguyen
2021-07-23 17:10 ` [PATCH net 4/5] i40e: Fix queue-to-TC mapping on Tx Tony Nguyen
2021-07-23 17:10 ` [PATCH net 5/5] i40e: Fix log TC creation failure when max num of queues is exceeded Tony Nguyen
2021-07-23 21:10 ` [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net 2/5] i40e: Fix firmware LLDP agent related warning' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).