Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>,
	netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
	sassmann@redhat.com,
	Michal Maloszewski <michal.maloszewski@intel.com>,
	Tony Brelinski <tonyx.brelinski@intel.com>
Subject: [PATCH net 3/5] i40e: Add additional info to PHY type error
Date: Fri, 23 Jul 2021 10:10:21 -0700	[thread overview]
Message-ID: <20210723171023.296927-4-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210723171023.296927-1-anthony.l.nguyen@intel.com>

From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>

In case of PHY type error occurs, the message was too generic.
Add additional info to PHY type error indicating that it can be
wrong cable connected.

Fixes: 124ed15bf126 ("i40e: Add dual speed module support")
Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index d9e26f9713a5..2c9e4eeb7270 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -980,7 +980,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,
 	default:
 		/* if we got here and link is up something bad is afoot */
 		netdev_info(netdev,
-			    "WARNING: Link is up but PHY type 0x%x is not recognized.\n",
+			    "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n",
 			    hw_link_info->phy_type);
 	}
 
-- 
2.26.2


  parent reply	other threads:[~2021-07-23 17:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 17:10 [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 Tony Nguyen
2021-07-23 17:10 ` [PATCH net 1/5] i40e: Fix logic of disabling queues Tony Nguyen
2021-07-23 17:10 ` [PATCH net 2/5] i40e: Fix firmware LLDP agent related warning Tony Nguyen
2021-07-23 17:10 ` Tony Nguyen [this message]
2021-07-23 17:10 ` [PATCH net 4/5] i40e: Fix queue-to-TC mapping on Tx Tony Nguyen
2021-07-23 17:10 ` [PATCH net 5/5] i40e: Fix log TC creation failure when max num of queues is exceeded Tony Nguyen
2021-07-23 21:10 ` [PATCH net 0/5][pull request] Intel Wired LAN Driver Updates 2021-07-23 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723171023.296927-4-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lukaszx.cieplicki@intel.com \
    --cc=michal.maloszewski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=tonyx.brelinski@intel.com \
    --subject='Re: [PATCH net 3/5] i40e: Add additional info to PHY type error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).