Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Frank Rowand <frowand.list@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 07/54] dt-bindings: bluetooth: broadcom: Fix clocks check
Date: Fri, 23 Jul 2021 15:38:43 -0600	[thread overview]
Message-ID: <20210723213843.GA2634543@robh.at.kernel.org> (raw)
In-Reply-To: <20210721140424.725744-8-maxime@cerno.tech>

On Wed, 21 Jul 2021 16:03:37 +0200, Maxime Ripard wrote:
> The original binding was mentioning that valid values for the clocks and
> clock-names property were one or two clocks from extclk, txco and lpo,
> with extclk being deprecated in favor of txco.
> 
> However, the current binding lists a valid array as extclk, txco and
> lpo, with either one or two items.
> 
> While this looks similar, it actually enforces that all the device trees
> use either ["extclk"], or ["extclk", "txco"]. That doesn't make much
> sense, since the two clocks are said to be equivalent, with one
> superseeding the other.
> 
> lpo is also not a valid clock anymore, and would be as the third clock
> of the list, while we could have only this clock in the previous binding
> (and in DTs).
> 
> Let's rework the clock clause to allow to have either:
> 
>  - extclk, and mark it a deprecated
>  - txco alone
>  - lpo alone
>  - txco, lpo
> 
> While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device
> tree so it's not an issue in practice.
> 
> Similarly, ["lpo", "txco"] is still considered invalid, but it's
> generally considered as a best practice to fix the order of clocks.
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../bindings/net/broadcom-bluetooth.yaml        | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2021-07-23 21:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210721140424.725744-1-maxime@cerno.tech>
2021-07-21 14:03 ` Maxime Ripard
2021-07-23 21:38   ` Rob Herring [this message]
2021-07-21 14:03 ` [PATCH 08/54] dt-bindings: bluetooth: realtek: Add missing max-speed Maxime Ripard
2021-07-23 21:39   ` Rob Herring
2021-07-23 22:56   ` Alistair
2021-07-21 14:03 ` [PATCH 26/54] dt-bindings: net: dwmac: Fix typo in the R40 compatible Maxime Ripard
2021-07-23 21:57   ` Rob Herring
2021-07-21 14:03 ` [PATCH 27/54] dt-bindings: net: wireless: Convert ESP ESP8089 binding to a schema Maxime Ripard
2021-07-23 21:58   ` Rob Herring
2021-08-06  8:47   ` Kalle Valo
     [not found]   ` <20210806084709.0C279C4338A@smtp.codeaurora.org>
2021-08-18  8:45     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723213843.GA2634543@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jernej.skrabec@siol.net \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime@cerno.tech \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH 07/54] dt-bindings: bluetooth: broadcom: Fix clocks check' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).