Netdev Archive on
help / color / mirror / Atom feed
From: Steffen Klassert <>
To: Corey Minyard <>
Cc: Herbert Xu <>,
	"David S. Miller" <>,
	<>, <>
Subject: Re: IPSec questions and comments
Date: Mon, 26 Jul 2021 10:13:50 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 23, 2021 at 08:01:17PM -0500, Corey Minyard wrote:
> <>, "David S. Miller" <>
> Cc:,
> Bcc: 
> Subject: IPSec questions
> Reply-To:
> I've been going through the XFRM code trying to understand it.  I've
> been documenting things in the code as I go.
> I have a specific usage question, then a general question:
> 1) In struct xfrm_dst, what is the difference between the route and path
> fields?  From what I can tell, in the first element of a bundle they
> will both point the route the packet will take after it has been
> transformed.  In the other elements of a bundle, route is the same as in
> the first element and path will be NULL.  Is this really the intent?
> Can path just be eliminated?

Eyal gave a good explanation of this.

> 2) This code is really hard to understand.  Nobody should have to go
> through what I'm going through.  If I can convince my employer to allow
> me to submit the comments I'm adding, would that be something acceptable?
> It would obviously take a lot of time to review.  If nobody's going to
> have the time to review it, I don't need to put forth the extra effort
> to make it submittable.

Documentation is always welcome. If you submit your documentation
in small reviewable patches, then it should be accepted and merged
over time.

      parent reply	other threads:[~2021-07-26  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  1:01 IPSec questions and comments Corey Minyard
2021-07-24  2:40 ` Eyal Birger
     [not found] ` <>
2021-07-24  6:15   ` question about configuring multiple interfaces on a host within the same ipv6 sub-net hui wang
2021-07-25  2:32     ` hui wang
2021-07-26  8:13 ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).