Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Steve Bennett <steveb@workware.net.au>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: Fix detection of ksz87xx switch
Date: Fri, 30 Jul 2021 09:59:36 -0700	[thread overview]
Message-ID: <20210730095936.1420b930@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210730105120.93743-1-steveb@workware.net.au>

Please extend the CC list to the maintainers, and people who
worked on this driver in the past, especially Marek.

On Fri, 30 Jul 2021 20:51:20 +1000 Steve Bennett wrote:
> The previous logic was wrong such that the ksz87xx
> switch was not identified correctly.

Any more details of what is happening? Which extact device do you see
this problem on?

I presume ksz87xx devices used to work and gotten broken - would you
mind clarifying and adding a Fixes tag to help backporting to the
correct stable branches?

> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 4d53886f7d51..a4acec02c8cb 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -401,11 +401,11 @@ static int ksz8041_config_aneg(struct phy_device *phydev)
>  }
>  
>  static int ksz8051_ksz8795_match_phy_device(struct phy_device *phydev,
> -					    const u32 ksz_phy_id)
> +					    const u32 ksz_8051)

bool and use true/false in the callers?


  reply	other threads:[~2021-07-30 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:51 Steve Bennett
2021-07-30 16:59 ` Jakub Kicinski [this message]
2021-07-30 22:19   ` Steve Bennett
2021-08-07  0:01     ` Ben Hutchings
2021-08-07  0:06       ` [PATCH net] net: phy: micrel: Fix link detection on ksz87xx switch" Ben Hutchings
2021-08-08 11:10         ` patchwork-bot+netdevbpf
2021-08-08 22:18       ` [PATCH] net: phy: micrel: Fix detection of ksz87xx switch Steve Bennett
2021-07-30 22:57 ` [PATCH v2] " Steve Bennett
2021-07-30 23:08   ` Marek Vasut
2021-08-02 14:10   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730095936.1420b930@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steveb@workware.net.au \
    --subject='Re: [PATCH] net: phy: micrel: Fix detection of ksz87xx switch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).