Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Stefan Mätje" <Stefan.Maetje@esd.eu>
To: linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfgang Grandegger <wg@grandegger.com>
Cc: netdev@vger.kernel.org, "Stefan Mätje" <Stefan.Maetje@esd.eu>
Subject: [PATCH v2 0/1] can: esd: add support for esd GmbH PCIe/402 CAN interface family
Date: Fri, 30 Jul 2021 19:38:04 +0200	[thread overview]
Message-ID: <20210730173805.3926-1-Stefan.Maetje@esd.eu> (raw)

The purpose of this patch is to introduce a new CAN driver to support
the esd GmbH 402 family of CAN interface boards. The hardware design
is based on a CAN controller implemented in a FPGA attached to a
PCIe link.

More information on these boards can be found following the links
included in the commit message.

This patch supports all boards but will operate the CAN-FD capable
boards only in Classic-CAN mode. The CAN-FD support will be added
when the initial patch has stabilized.

The patch is based on the linux-can-next testing branch.

The patch is uses the previous work of my former colleague:
Link: https://lore.kernel.org/linux-can/1426592308-23817-1-git-send-email-thomas.koerper@esd.eu/

*Note*: scripts/checkpatch.pl still emits the following warnings:
1.esd402_pci.c:293: Still prints the non-hashed virtual address for
  debug purposes with pci_err(). This is done only on fatal
  initialization failure during modprobe and seems sensible in this
  case to debug the error. This will never occur in normal operation.
2.esdacc.h:269: The irq_cnt pointer is still declared volatile and
  this has a reason and is explained in detail in the header
  referencing the exception noted in volatile-considered-harmful.rst.

Changes in v2:
- Avoid warning triggered by -Wshift-count-overflow on architectures
  with 32-bit dma_addr_t.
- Fixed Makefile not to build the kernel module always. Doing this
  renamed esd402_pci.c to esd_402_pci-core.c as recommended by Marc.

Stefan Mätje (1):
  can: esd: add support for esd GmbH PCIe/402 CAN interface family

 drivers/net/can/Kconfig                |   1 +
 drivers/net/can/Makefile               |   1 +
 drivers/net/can/esd/Kconfig            |  12 +
 drivers/net/can/esd/Makefile           |   7 +
 drivers/net/can/esd/esd_402_pci-core.c | 530 ++++++++++++++++++
 drivers/net/can/esd/esdacc.c           | 717 +++++++++++++++++++++++++
 drivers/net/can/esd/esdacc.h           | 394 ++++++++++++++
 7 files changed, 1662 insertions(+)
 create mode 100644 drivers/net/can/esd/Kconfig
 create mode 100644 drivers/net/can/esd/Makefile
 create mode 100644 drivers/net/can/esd/esd_402_pci-core.c
 create mode 100644 drivers/net/can/esd/esdacc.c
 create mode 100644 drivers/net/can/esd/esdacc.h


base-commit: 8dad5561c13ade87238d9de6dd410b43f7562447
-- 
2.25.1


             reply	other threads:[~2021-07-30 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 17:38 Stefan Mätje [this message]
2021-07-30 17:38 ` [PATCH v2 1/1] can: esd: add support for esd GmbH PCIe/402 CAN interface family Stefan Mätje
2021-08-06 13:31   ` Marc Kleine-Budde
2021-08-16 22:04     ` Stefan Mätje
2021-08-17  0:14       ` Vincent MAILHOL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730173805.3926-1-Stefan.Maetje@esd.eu \
    --to=stefan.maetje@esd.eu \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).