Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: <davem@davemloft.net>, <richardcochran@gmail.com>,
	<netdev@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH net-next] ptp: ocp: Expose various resources on the timecard.
Date: Sat, 31 Jul 2021 08:06:37 -0700	[thread overview]
Message-ID: <20210731080637.231d89e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210730201354.1237659-1-jonathan.lemon@gmail.com>

On Fri, 30 Jul 2021 13:13:54 -0700 Jonathan Lemon wrote:
> The OpenCompute timecard driver has additional functionality besides
> a clock.  Make the following resources available:
> 
>  - The external timestamp channels (ts0/ts1)
>  - devlink support for flashing and health reporting
>  - GPS and MAC serial ports
>  - board serial number (obtained from i2c device)
> 
> Also add watchdog functionality for when GNSS goes into holdover.

drivers/ptp/ptp_ocp.c: In function ‘ptp_ocp_init’:
drivers/ptp/ptp_ocp.c:1600:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
1600 |  int err;
     |      ^~~
drivers/ptp/ptp_ocp.c:1153:69: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:1506:27: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:1587:31: warning: Using plain integer as NULL pointer
drivers/ptp/ptp_ocp.c:881:29: warning: dereference of noderef expression
drivers/ptp/ptp_ocp.c:1399:29: warning: dereference of noderef expression

      parent reply	other threads:[~2021-07-31 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 20:13 Jonathan Lemon
2021-07-31  1:18 ` kernel test robot
2021-07-31 15:06 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210731080637.231d89e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jonathan.lemon@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --subject='Re: [PATCH net-next] ptp: ocp: Expose various resources on the timecard.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).