Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] neighbour: Rename procfs entry
Date: Mon, 2 Aug 2021 09:30:50 -0700	[thread overview]
Message-ID: <20210802093050.67c361f4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210802035745.29934-1-yajun.deng@linux.dev>

On Mon,  2 Aug 2021 11:57:45 +0800 Yajun Deng wrote:
> Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}.
> This is more friendly for user.

We can't rename files in procfs after they had been present 
in an official kernel release. They are uABI. Same goes for 
your default -> current rename patch.

You also forgot to update documentation. 

      reply	other threads:[~2021-08-02 16:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  3:57 Yajun Deng
2021-08-02 16:30 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802093050.67c361f4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yajun.deng@linux.dev \
    --subject='Re: [PATCH net-next] neighbour: Rename procfs entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).