Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Nicholas Richardson <richardsonnick@google.com>
Cc: davem@davemloft.net, nrrichar@ncsu.edu, arunkaly@google.com,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Leesoo Ahn <dev@ooseel.net>, Di Zhu <zhudi21@huawei.com>,
	Yejune Deng <yejune.deng@gmail.com>, Ye Bin <yebin10@huawei.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pktgen: Fix invalid clone_skb override
Date: Mon, 2 Aug 2021 10:21:00 -0700	[thread overview]
Message-ID: <20210802102100.5292367a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210802171210.2191096-1-richardsonnick@google.com>

On Mon,  2 Aug 2021 17:12:07 +0000 Nicholas Richardson wrote:
> From: Nick Richardson <richardsonnick@google.com>
> 
> When the netif_receive xmit_mode is set, a line is supposed to set
> clone_skb to a default 0 value. This line is not reached due to a line
> that checks if clone_skb is more than zero and returns -ENOTSUPP.
> 
> Removes line that defaults clone_skb to zero.

s/Removes/Remove/
s/defaults/sets/

> -ENOTSUPP is returned
> if clone_skb is more than zero. 

That's already mentioned in the previous paragraph.

> If clone_skb is equal to zero then the
> xmit_mode is set to netif_receive as usual and no error is returned.

Please add the explanation why clone_skb can't be negative to the
commit message.

  reply	other threads:[~2021-08-02 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210802071126.3b311638@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-08-02 17:09 ` [PATCH net-next] " Nicholas Richardson
2021-08-02 17:12 ` [PATCH v2] " Nicholas Richardson
2021-08-02 17:21   ` Jakub Kicinski [this message]
2021-08-02 18:20     ` [PATCH v3] " Nicholas Richardson
2021-08-03  2:17       ` 答复: " zhudi (J)
2021-08-03 16:27         ` [PATCH v4] pktgen: Remove redundant " Nicholas Richardson
2021-08-04 12:00           ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802102100.5292367a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=arunkaly@google.com \
    --cc=davem@davemloft.net \
    --cc=dev@ooseel.net \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nrrichar@ncsu.edu \
    --cc=richardsonnick@google.com \
    --cc=yebin10@huawei.com \
    --cc=yejune.deng@gmail.com \
    --cc=zhudi21@huawei.com \
    --subject='Re: [PATCH v2] pktgen: Fix invalid clone_skb override' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).