Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicholas Richardson <richardsonnick@google.com>
To: kuba@kernel.org
Cc: nrrichar@ncsu.edu, arunkaly@google.com, netdev@vger.kernel.org,
	Nicholas Richardson <richardsonnick@google.com>
Subject: Re: [PATCH net-next] pktgen: Fix invalid clone_skb override
Date: Mon,  2 Aug 2021 17:09:10 +0000	[thread overview]
Message-ID: <20210802170910.2190218-1-richardsonnick@google.com> (raw)
In-Reply-To: <20210802071126.3b311638@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

When a user passes a negative value for clone_skb, the num_args() function stops parsing at the first nonnumeric value. This makes it impossible for clone_skb to be set to a negative value. For example: "clone_skb -200" would stop parsing at the first char ('-') and return zero for the new clone_skb value.

So to answer your question: No clone_skb cannot be negative.

Apologies for the email format errors and thanks for the quick reply!

       reply	other threads:[~2021-08-02 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210802071126.3b311638@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-08-02 17:09 ` Nicholas Richardson [this message]
2021-08-02 17:12 ` [PATCH v2] " Nicholas Richardson
2021-08-02 17:21   ` Jakub Kicinski
2021-08-02 18:20     ` [PATCH v3] " Nicholas Richardson
2021-08-03  2:17       ` 答复: " zhudi (J)
2021-08-03 16:27         ` [PATCH v4] pktgen: Remove redundant " Nicholas Richardson
2021-08-04 12:00           ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802170910.2190218-1-richardsonnick@google.com \
    --to=richardsonnick@google.com \
    --cc=arunkaly@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nrrichar@ncsu.edu \
    --subject='Re: [PATCH net-next] pktgen: Fix invalid clone_skb override' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).