Netdev Archive on
help / color / mirror / Atom feed
From: kernel test robot <>
To: Hao Chen <>,
	Hao Chen <>
Subject: Re: [net-next,v8] net: stmmac: optimize check in ops '.begin'
Date: Tue, 3 Aug 2021 17:01:53 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 3101 bytes --]

Hi Hao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipvs/master]
[also build test ERROR on linus/master v5.14-rc4 next-20210802]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: master
config: x86_64-randconfig-a003-20210802 (attached as .config)
compiler: clang version 13.0.0 ( 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
        wget -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add linux-review
        git fetch --no-tags linux-review Hao-Chen/net-stmmac-optimize-check-in-ops-begin/20210803-104151
        git checkout a618eda31260a301aadf7987885767f905c5320a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:378:7: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
                   u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:35: error: passing 'struct device' to parameter of incompatible type 'struct device *'; take the address with &
           return pm_runtime_resume_and_get(dev->dev);
   include/linux/pm_runtime.h:400:60: note: passing argument to parameter 'dev' here
   static inline int pm_runtime_resume_and_get(struct device *dev)
   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:421:17: error: passing 'struct device' to parameter of incompatible type 'struct device *'; take the address with &
   include/linux/pm_runtime.h:420:49: note: passing argument to parameter 'dev' here
   static inline int pm_runtime_put(struct device *dev)
   1 warning and 2 errors generated.

vim +416 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

   414	static int stmmac_ethtool_begin(struct net_device *dev)
   415	{
 > 416		return pm_runtime_resume_and_get(dev->dev);
   417	}

0-DAY CI Kernel Test Service, Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34990 bytes --]

  parent reply	other threads:[~2021-08-03  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  2:38 Hao Chen
2021-08-03  6:04 ` Heiner Kallweit
2021-08-03  9:01 ` kernel test robot [this message]
2021-08-03 10:33 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-08-03  2:37 Hao Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [net-next,v8] net: stmmac: optimize check in ops '\''.begin'\''' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).