Re: [PATCH net-next] Revert "netdevsim: Add multi-queue support"

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 4 Aug 2021 10:14:36 +0300 Leon Romanovsky wrote:
> On Tue, Aug 03, 2021 at 02:51:24PM -0700, Jakub Kicinski wrote:
> > On Tue, 3 Aug 2021 14:32:19 -0700 Cong Wang wrote:  
> > > On Tue, Aug 3, 2021 at 2:18 PM Jakub Kicinski <kuba@kernel.org> wrote:  
> 
> <...>
> 
> > > Please remove all those not covered by upstream tests just to be fair??  
> > 
> > I'd love to remove all test harnesses upstream which are not used by
> > upstream tests, sure :)  
> 
> Jakub,
> 
> Something related and unrelated at the same time.
> 
> I need to get rid of devlink_reload_enable()/_disable() to fix some
> panics in the devlink reload flow.
> 
> Such change is relatively easy for the HW drivers, but not so for the
> netdevism due to attempt to synchronize sysfs with devlink.
> 
>   200         mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
>   201         devlink_reload_disable(devlink);
>   202         ret = nsim_dev_port_add(nsim_bus_dev, NSIM_DEV_PORT_TYPE_PF, port_index);
>   203         devlink_reload_enable(devlink);
>   204         mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
> 
> Are these sysfs files declared as UAPI? Or can I update upstream test
> suite and delete them safely?

You can change netdevsim in whatever way is appropriate.

What's your plan, tho? Jiri changed the spawning from rtnetlink 
to sysfs - may be good to consult with him before typing too much 
code.