Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	<netdev@vger.kernel.org>
Subject: [PATCH 6/6] net: xfrm: Fix end of loop tests for list_for_each_entry
Date: Wed, 4 Aug 2021 09:03:29 +0200	[thread overview]
Message-ID: <20210804070329.1357123-7-steffen.klassert@secunet.com> (raw)
In-Reply-To: <20210804070329.1357123-1-steffen.klassert@secunet.com>

From: Harshvardhan Jha <harshvardhan.jha@oracle.com>

The list_for_each_entry() iterator, "pos" in this code, can never be
NULL so the warning will never be printed.

Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
 net/xfrm/xfrm_ipcomp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c
index 2e8afe078d61..cb40ff0ff28d 100644
--- a/net/xfrm/xfrm_ipcomp.c
+++ b/net/xfrm/xfrm_ipcomp.c
@@ -241,7 +241,7 @@ static void ipcomp_free_tfms(struct crypto_comp * __percpu *tfms)
 			break;
 	}
 
-	WARN_ON(!pos);
+	WARN_ON(list_entry_is_head(pos, &ipcomp_tfms_list, list));
 
 	if (--pos->users)
 		return;
-- 
2.25.1


  parent reply	other threads:[~2021-08-04  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  7:03 pull request (net): ipsec 2021-08-04 Steffen Klassert
2021-08-04  7:03 ` [PATCH 1/6] net: xfrm: fix memory leak in xfrm_user_rcv_msg Steffen Klassert
2021-08-04 10:10   ` patchwork-bot+netdevbpf
2021-08-04  7:03 ` [PATCH 2/6] Revert "xfrm: policy: Read seqcount outside of rcu-read side in xfrm_policy_lookup_bytype" Steffen Klassert
2021-08-04  7:03 ` [PATCH 3/6] xfrm: Fix RCU vs hash_resize_mutex lock inversion Steffen Klassert
2021-08-04  7:03 ` [PATCH 4/6] net/xfrm/compat: Copy xfrm_spdattr_type_t atributes Steffen Klassert
2021-08-04  7:03 ` [PATCH 5/6] selftests/net/ipsec: Add test for xfrm_spdattr_type_t Steffen Klassert
2021-08-04  7:03 ` Steffen Klassert [this message]
2021-08-04 10:10 ` pull request (net): ipsec 2021-08-04 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804070329.1357123-7-steffen.klassert@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 6/6] net: xfrm: Fix end of loop tests for list_for_each_entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).