Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
To: netdev@vger.kernel.org
Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
krishna.c.sudi@intel.com, linuxwwan@intel.com
Subject: [PATCH 4/4] net: wwan: iosm: fix recursive lock acquire in unregister
Date: Wed, 4 Aug 2021 21:39:52 +0530 [thread overview]
Message-ID: <20210804160952.70254-5-m.chetan.kumar@linux.intel.com> (raw)
In-Reply-To: <20210804160952.70254-1-m.chetan.kumar@linux.intel.com>
Calling unregister_netdevice() inside wwan del link is trying to
acquire the held lock in ndo_stop_cb(). Instead, queue net dev to
be unregistered later.
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
---
drivers/net/wwan/iosm/iosm_ipc_wwan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
index b2357ad5d517..b571d9cedba4 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
@@ -228,7 +228,7 @@ static void ipc_wwan_dellink(void *ctxt, struct net_device *dev,
RCU_INIT_POINTER(ipc_wwan->sub_netlist[if_id], NULL);
/* unregistering includes synchronize_net() */
- unregister_netdevice(dev);
+ unregister_netdevice_queue(dev, head);
unlock:
mutex_unlock(&ipc_wwan->if_mutex);
--
2.25.1
next prev parent reply other threads:[~2021-08-04 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 16:09 [PATCH 0/4] net: wwan: iosm: fixes M Chetan Kumar
2021-08-04 16:09 ` [PATCH 1/4] net: wwan: iosm: fix lkp buildbot warning M Chetan Kumar
2021-08-04 16:09 ` [PATCH 2/4] net: wwan: iosm: endianness type correction M Chetan Kumar
2021-08-04 17:09 ` Loic Poulain
2021-08-04 16:09 ` [PATCH 3/4] net: wwan: iosm: correct data protocol mask bit M Chetan Kumar
2021-08-04 17:10 ` Loic Poulain
2021-08-04 16:09 ` M Chetan Kumar [this message]
2021-08-04 17:09 ` [PATCH 4/4] net: wwan: iosm: fix recursive lock acquire in unregister Loic Poulain
2021-08-05 10:30 ` [PATCH 0/4] net: wwan: iosm: fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804160952.70254-5-m.chetan.kumar@linux.intel.com \
--to=m.chetan.kumar@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=krishna.c.sudi@intel.com \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--subject='Re: [PATCH 4/4] net: wwan: iosm: fix recursive lock acquire in unregister' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).