Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "David S. Miller" <davem@davemloft.net>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Loic Poulain <loic.poulain@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jakub Kicinski <kuba@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))
Date: Fri, 6 Aug 2021 11:54:13 +0300 [thread overview]
Message-ID: <20210806085413.61536-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com>
ida_alloc_range)) may return other than -ENOMEM error code.
Unshadow it in the wwan_create_port().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: new patch
drivers/net/wwan/wwan_core.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 35ece98134c0..d293ab688044 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -359,8 +359,8 @@ struct wwan_port *wwan_create_port(struct device *parent,
{
struct wwan_device *wwandev;
struct wwan_port *port;
- int minor, err = -ENOMEM;
char namefmt[0x20];
+ int minor, err;
if (type > WWAN_PORT_MAX || !ops)
return ERR_PTR(-EINVAL);
@@ -374,11 +374,14 @@ struct wwan_port *wwan_create_port(struct device *parent,
/* A port is exposed as character device, get a minor */
minor = ida_alloc_range(&minors, 0, WWAN_MAX_MINORS - 1, GFP_KERNEL);
- if (minor < 0)
+ if (minor < 0) {
+ err = minor;
goto error_wwandev_remove;
+ }
port = kzalloc(sizeof(*port), GFP_KERNEL);
if (!port) {
+ err = -ENOMEM;
ida_free(&minors, minor);
goto error_wwandev_remove;
}
--
2.30.2
next prev parent reply other threads:[~2021-08-06 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 8:54 [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Andy Shevchenko
2021-08-06 8:54 ` Andy Shevchenko [this message]
2021-08-06 9:17 ` [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range)) Sergey Ryazanov
2021-08-06 14:19 ` Andy Shevchenko
2021-08-06 20:35 ` Sergey Ryazanov
2021-08-11 12:50 ` Andy Shevchenko
2021-08-06 9:32 ` Loic Poulain
2021-08-06 9:15 ` [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Sergey Ryazanov
2021-08-06 9:29 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806085413.61536-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--subject='Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).