Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, oss-drivers@corigine.com,
	Fei Qin <fei.qin@corigine.com>,
	Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
Date: Fri, 6 Aug 2021 11:38:57 +0200	[thread overview]
Message-ID: <20210806093856.GA28022@corigine.com> (raw)
In-Reply-To: <20210803155023.GC17597@corigine.com>

On Tue, Aug 03, 2021 at 05:50:26PM +0200, Simon Horman wrote:
> On Tue, Aug 03, 2021 at 05:03:33PM +0200, Andrew Lunn wrote:
> > On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> > > From: Fei Qin <fei.qin@corigine.com>
> > > 
> > > Pauseframe control is set to symmetric mode by default on the NFP.
> > > Pause frames can not be configured through ethtool now, but ethtool can
> > > report the supported mode.
> > > 
> > > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> > > Signed-off-by: Fei Qin <fei.qin@corigine.com>
> > > Signed-off-by: Louis Peens <louis.peens@corigine.com>
> > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > ---
> > >  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > index 1b482446536d..8803faadd302 100644
> > > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
> > >  
> > >  	/* Init to unknowns */
> > >  	ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> > > +	ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> > > +	ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> > 
> > Hi Simon
> > 
> > Does it act on the results of the pause auto-neg? If the link peer
> > says it does not support pause, will it turn pause off?
> 
> Thanks Andrew,
> 
> I'll try and get an answer to that question for you.

Hi Andrew,

The simple answer to those questions is no.

  reply	other threads:[~2021-08-06  9:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 10:39 Simon Horman
2021-08-03 12:00 ` patchwork-bot+netdevbpf
2021-08-03 15:03 ` Andrew Lunn
2021-08-03 15:50   ` Simon Horman
2021-08-06  9:38     ` Simon Horman [this message]
2021-08-07  2:17       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806093856.GA28022@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=fei.qin@corigine.com \
    --cc=kuba@kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --subject='Re: [PATCH net] nfp: update ethtool reporting of pauseframe control' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).