Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Guangbin Huang <huangguangbin2@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lipeng321@huawei.com>
Subject: Re: [PATCH net-next 4/4] net: hns3: add support ethtool extended link state
Date: Mon, 9 Aug 2021 13:54:56 -0700	[thread overview]
Message-ID: <20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1628520642-30839-5-git-send-email-huangguangbin2@huawei.com>

On Mon, 9 Aug 2021 22:50:42 +0800 Guangbin Huang wrote:
> +	if (!h->ae_algo->ops->get_link_diagnosis_info)
> +		return -EOPNOTSUP;

Missing a P at the end here, this patch does not build.

  reply	other threads:[~2021-08-09 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 14:50 [PATCH net-next 0/4] " Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 1/4] docs: ethtool: Add two link extended substates of bad signal integrity Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 2/4] ethtool: add " Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 3/4] net: hns3: add header file hns3_ethtoo.h Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 4/4] net: hns3: add support ethtool extended link state Guangbin Huang
2021-08-09 20:54   ` Jakub Kicinski [this message]
2021-08-10  1:08     ` huangguangbin (A)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=huangguangbin2@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 4/4] net: hns3: add support ethtool extended link state' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).