Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net,
	Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
	netdev@vger.kernel.org,
	Konrad Jankowski <konrad0.jankowski@intel.com>
Subject: Re: [PATCH net 2/4] ice: Stop processing VF messages during teardown
Date: Mon, 9 Aug 2021 15:58:38 -0700	[thread overview]
Message-ID: <20210809155838.208796aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210809171402.17838-3-anthony.l.nguyen@intel.com>

On Mon,  9 Aug 2021 10:14:00 -0700 Tony Nguyen wrote:
> When VFs are setup and torn down in quick succession, it is possible
> that a VF is torn down by the PF while the VF's virtchnl requests are
> still in the PF's mailbox ring. Processing the VF's virtchnl request
> when the VF itself doesn't exist results in undefined behavior. Fix
> this by adding a check to stop processing virtchnl requests when VF
> teardown is in progress.

What is "undefined behavior" in this context? Please improve the commit
message. It should describe misbehavior visible to the user, failing
that what will happen from kernel/device perspective. Or state that it's
just a "fix" to align with some internal driver <> firmware spec...

  reply	other threads:[~2021-08-09 22:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 17:13 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2021-08-09 Tony Nguyen
2021-08-09 17:13 ` [PATCH net 1/4] ice: Prevent probing virtual functions Tony Nguyen
2021-08-09 22:56   ` Jakub Kicinski
2021-08-09 17:14 ` [PATCH net 2/4] ice: Stop processing VF messages during teardown Tony Nguyen
2021-08-09 22:58   ` Jakub Kicinski [this message]
2021-08-10 17:42     ` Venkataramanan, Anirudh
2021-08-10 14:30   ` Jonathan Toppins
2021-08-09 17:14 ` [PATCH net 3/4] ice: don't remove netdev->dev_addr from uc sync list Tony Nguyen
2021-08-10 14:29   ` Jonathan Toppins
2021-08-09 17:14 ` [PATCH net 4/4] iavf: Set RSS LUT and key in reset handle path Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809155838.208796aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=anirudh.venkataramanan@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=konrad0.jankowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net 2/4] ice: Stop processing VF messages during teardown' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).