Netdev Archive on
help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <>
To: Amitkumar Karwar <>,
	Ganapathi Bhat <>,
	Sharvari Harisangam <>,
	Xinming Hu <>,
	Kalle Valo <>,
	"David S. Miller" <>,
	Jakub Kicinski <>
	"Gustavo A. R. Silva" <>,
Subject: [PATCH][next] mwifiex: usb: Replace one-element array with flexible-array member
Date: Mon, 9 Aug 2021 16:11:34 -0500	[thread overview]
Message-ID: <20210809211134.GA22488@embeddedor> (raw)

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].

This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().

This issue was found with the help of Coccinelle and audited and fixed,


Signed-off-by: Gustavo A. R. Silva <>
 drivers/net/wireless/marvell/mwifiex/usb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/usb.h b/drivers/net/wireless/marvell/mwifiex/usb.h
index d822ec15b7e6..61a96b7fbf21 100644
--- a/drivers/net/wireless/marvell/mwifiex/usb.h
+++ b/drivers/net/wireless/marvell/mwifiex/usb.h
@@ -134,7 +134,7 @@ struct fw_sync_header {
 struct fw_data {
 	struct fw_header fw_hdr;
 	__le32 seq_num;
-	u8 data[1];
+	u8 data[];
 } __packed;
 #endif /*_MWIFIEX_USB_H */

             reply	other threads:[~2021-08-09 21:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 21:11 Gustavo A. R. Silva [this message]
2021-08-09 21:24 ` [PATCH][next] mwifiex: usb: Replace one-element array with flexible-array member Brian Norris
2021-08-09 21:32   ` Gustavo A. R. Silva
2021-08-21 17:50 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809211134.GA22488@embeddedor \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).