Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lahav Schlesinger <lschlesinger@drivenets.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: netdev@vger.kernel.org, dsahern@kernel.org, davem@davemloft.net,
	kuba@kernel.org
Subject: Re: [PATCH net-next v3] net: Support filtering interfaces on no master
Date: Tue, 10 Aug 2021 10:26:08 +0300	[thread overview]
Message-ID: <20210810072608.haanbwgpijyfxgjl@kgollan-pc> (raw)
In-Reply-To: <YRIm1deoDLl37V8n@unreal>

On Tue, Aug 10, 2021 at 10:12:21AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 10, 2021 at 06:49:43AM +0000, Lahav Schlesinger wrote:
> > Currently there's support for filtering neighbours/links for interfaces
> > which have a specific master device (using the IFLA_MASTER/NDA_MASTER
> > attributes).
> >
> > This patch adds support for filtering interfaces/neighbours dump for
> > interfaces that *don't* have a master.
> >
>
> .....
>
> > I have a patch for iproute2 ready for adding this support in userspace.
> >
> > v2 -> v3
> >  - Change the way 'master' is checked for being non NULL
> > v1 -> v2
> >  - Change from filtering just for non VRF slaves to non slaves at all
> >
>
> The above lines don't belong to commit message. Please put them under "---"
>
> Thanks
>

Oops, sorry about that!

> > Signed-off-by: Lahav Schlesinger <lschlesinger@drivenets.com>
> > Cc: David Ahern <dsahern@kernel.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > ---
> >  net/core/neighbour.c | 7 +++++++
> >  net/core/rtnetlink.c | 7 +++++++
> >  2 files changed, 14 insertions(+)
> >
> > diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> > index b963d6b02c4f..2d5bc3a75fae 100644
> > --- a/net/core/neighbour.c
> > +++ b/net/core/neighbour.c
> > @@ -2528,6 +2528,13 @@ static bool neigh_master_filtered(struct net_device *dev, int master_idx)
> >  		return false;
> >
> >  	master = dev ? netdev_master_upper_dev_get(dev) : NULL;
> > +
> > +	/* 0 is already used to denote NDA_MASTER wasn't passed, therefore need another
> > +	 * invalid value for ifindex to denote "no master".
> > +	 */
> > +	if (master_idx == -1)
> > +		return !!master;
> > +
> >  	if (!master || master->ifindex != master_idx)
> >  		return true;
> >
> > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> > index 7c9d32cfe607..2dcf1c084b20 100644
> > --- a/net/core/rtnetlink.c
> > +++ b/net/core/rtnetlink.c
> > @@ -1959,6 +1959,13 @@ static bool link_master_filtered(struct net_device *dev, int master_idx)
> >  		return false;
> >
> >  	master = netdev_master_upper_dev_get(dev);
> > +
> > +	/* 0 is already used to denote IFLA_MASTER wasn't passed, therefore need
> > +	 * another invalid value for ifindex to denote "no master".
> > +	 */
> > +	if (master_idx == -1)
> > +		return !!master;
> > +
> >  	if (!master || master->ifindex != master_idx)
> >  		return true;
> >
> > --
> > 2.25.1
> >

  reply	other threads:[~2021-08-10  7:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  6:49 Lahav Schlesinger
2021-08-10  7:12 ` Leon Romanovsky
2021-08-10  7:26   ` Lahav Schlesinger [this message]
2021-08-10  7:27 Lahav Schlesinger
2021-08-10  8:39 ` Leon Romanovsky
2021-08-10  9:06 Lahav Schlesinger
2021-08-10  9:37 ` Leon Romanovsky
2021-08-10 13:19 ` David Ahern
2021-08-10 23:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210810072608.haanbwgpijyfxgjl@kgollan-pc \
    --to=lschlesinger@drivenets.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next v3] net: Support filtering interfaces on no master' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).