Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* Bridge port isolation offload
@ 2021-08-10  4:40 DENG Qingfang
  2021-08-10  9:43 ` Florian Fainelli
  2021-08-10 10:42 ` Vladimir Oltean
  0 siblings, 2 replies; 3+ messages in thread
From: DENG Qingfang @ 2021-08-10  4:40 UTC (permalink / raw)
  To: Roopa Prabhu, Nikolay Aleksandrov, David Miller, Andrew Lunn,
	Florian Fainelli, Jakub Kicinski, bridge, netdev, Vivien Didelot,
	Vladimir Oltean

Hi,

Bridge port isolation flag (BR_ISOLATED) was added in commit
7d850abd5f4e. But switchdev does not offload it currently.
It should be easy to implement in drivers, just like bridge offload
but prevent isolated ports to communicate with each other.

Your thoughts?

Regards,
  Qingfang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bridge port isolation offload
  2021-08-10  4:40 Bridge port isolation offload DENG Qingfang
@ 2021-08-10  9:43 ` Florian Fainelli
  2021-08-10 10:42 ` Vladimir Oltean
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-08-10  9:43 UTC (permalink / raw)
  To: DENG Qingfang, Roopa Prabhu, Nikolay Aleksandrov, David Miller,
	Andrew Lunn, Jakub Kicinski, bridge, netdev, Vivien Didelot,
	Vladimir Oltean



On 8/9/2021 9:40 PM, DENG Qingfang wrote:
> Hi,
> 
> Bridge port isolation flag (BR_ISOLATED) was added in commit
> 7d850abd5f4e. But switchdev does not offload it currently.
> It should be easy to implement in drivers, just like bridge offload
> but prevent isolated ports to communicate with each other.
> 
> Your thoughts?

It maps well on Broadcom switches but there was not a known use case 
AFAICT that warranted mapping this flag to program the switch hardware 
accordingly.
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bridge port isolation offload
  2021-08-10  4:40 Bridge port isolation offload DENG Qingfang
  2021-08-10  9:43 ` Florian Fainelli
@ 2021-08-10 10:42 ` Vladimir Oltean
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2021-08-10 10:42 UTC (permalink / raw)
  To: DENG Qingfang
  Cc: Roopa Prabhu, Nikolay Aleksandrov, David Miller, Andrew Lunn,
	Florian Fainelli, Jakub Kicinski, bridge, netdev, Vivien Didelot

On Tue, Aug 10, 2021 at 12:40:49PM +0800, DENG Qingfang wrote:
> Hi,
> 
> Bridge port isolation flag (BR_ISOLATED) was added in commit
> 7d850abd5f4e. But switchdev does not offload it currently.
> It should be easy to implement in drivers, just like bridge offload
> but prevent isolated ports to communicate with each other.
> 
> Your thoughts?

If nothing else, do add BR_ISOLATED to BR_PORT_FLAGS_HW_OFFLOAD so that
switchdev drivers which have an offloaded data plane have a chance to
reject this new bridge port flag if they don't support it yet.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-10 10:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10  4:40 Bridge port isolation offload DENG Qingfang
2021-08-10  9:43 ` Florian Fainelli
2021-08-10 10:42 ` Vladimir Oltean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).