Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: Parav Pandit <parav@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	"Leon Romanovsky" <leonro@nvidia.com>
Subject: [PATCH net-next 04/10] devlink: Create a helper function for one parameter registration
Date: Tue, 10 Aug 2021 14:46:14 +0300	[thread overview]
Message-ID: <20210810114620.8397-5-parav@nvidia.com> (raw)
In-Reply-To: <20210810114620.8397-1-parav@nvidia.com>

Create and use a helper function for one parameter registration.
Subsequent patch also will reuse this for driver facing routine to
register a single parameter.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
---
 net/core/devlink.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 867ae7e39788..050dd7271a45 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -9800,6 +9800,22 @@ static int devlink_param_verify(const struct devlink_param *param)
 		return devlink_param_driver_verify(param);
 }
 
+static int __devlink_param_register_one(struct devlink *devlink,
+					unsigned int port_index,
+					struct list_head *param_list,
+					const struct devlink_param *param,
+					enum devlink_command reg_cmd)
+{
+	int err;
+
+	err = devlink_param_verify(param);
+	if (err)
+		return err;
+
+	return devlink_param_register_one(devlink, port_index,
+					  param_list, param, reg_cmd);
+}
+
 static int __devlink_params_register(struct devlink *devlink,
 				     unsigned int port_index,
 				     struct list_head *param_list,
@@ -9814,12 +9830,8 @@ static int __devlink_params_register(struct devlink *devlink,
 
 	mutex_lock(&devlink->lock);
 	for (i = 0; i < params_count; i++, param++) {
-		err = devlink_param_verify(param);
-		if (err)
-			goto rollback;
-
-		err = devlink_param_register_one(devlink, port_index,
-						 param_list, param, reg_cmd);
+		err = __devlink_param_register_one(devlink, port_index,
+						   param_list, param, reg_cmd);
 		if (err)
 			goto rollback;
 	}
-- 
2.26.2


  parent reply	other threads:[~2021-08-10 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 11:46 [PATCH net-next 00/10] devlink: Control auxiliary devices Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 01/10] devlink: Add new "enable_eth" generic device param Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 02/10] devlink: Add new "enable_rdma" " Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 03/10] devlink: Add new "enable_vnet" " Parav Pandit
2021-08-10 11:46 ` Parav Pandit [this message]
2021-08-10 11:46 ` [PATCH net-next 05/10] devlink: Add API to register and unregister single parameter Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 06/10] devlink: Add APIs to publish, unpublish individual parameter Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 07/10] net/mlx5: Fix unpublish devlink parameters Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 08/10] net/mlx5: Support enable_eth devlink dev param Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 09/10] net/mlx5: Support enable_rdma " Parav Pandit
2021-08-10 11:46 ` [PATCH net-next 10/10] net/mlx5: Support enable_vnet " Parav Pandit
2021-08-10 11:59 ` [PATCH net-next 00/10] devlink: Control auxiliary devices Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210810114620.8397-5-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 04/10] devlink: Create a helper function for one parameter registration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).