Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs
Date: Tue, 10 Aug 2021 15:34:06 +0100	[thread overview]
Message-ID: <20210810143406.GC4704@sirena.org.uk> (raw)
In-Reply-To: <20210810125536.edr64jhzgr7rdnmd@skbuf>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On Tue, Aug 10, 2021 at 12:55:37PM +0000, Vladimir Oltean wrote:
> On Tue, Aug 10, 2021 at 01:37:48PM +0100, Mark Brown wrote:

> > The ocelot driver makes use of regmap, wrapping it with driver specific
> > operations that are thin wrappers around the core regmap APIs. These are
> > exported with EXPORT_SYMBOL, dropping the _GPL from the core regmap
> > exports which is frowned upon. Add _GPL suffixes to at least the APIs that
> > are doing register I/O.

> Stupid question: is this enough? We also have order-two symbols exported
> as non-GPL, which call one of {__ocelot_read_ix, __ocelot_write_ix,
> __ocelot_rmw_ix, ocelot_port_writel, ocelot_port_rmwl, ocelot_regfields_init,
> ocelot_regmap_init}, and therefore indirectly call regmap. In fact, I
> think that all symbols exported by ocelot do that.

Yes, that'd be much better I think - I have to confess I didn't look at
the driver in too much detail beyond these most obvious examples to
figure out how exactly they slotted in structurally.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-08-10 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 12:37 Mark Brown
2021-08-10 12:49 ` Alexandre Belloni
2021-08-10 12:55 ` Vladimir Oltean
2021-08-10 14:34   ` Mark Brown [this message]
2021-08-11 22:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210810143406.GC4704@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --subject='Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).