Netdev Archive on
help / color / mirror / Atom feed
From: Pablo Neira Ayuso <>
To: Pavel Skripkin <>
Subject: Re: [PATCH v2] netfilter: protect nft_ct_pcpu_template_refcnt with mutex
Date: Wed, 11 Aug 2021 11:22:02 +0200	[thread overview]
Message-ID: <20210811092201.GA23996@salvia> (raw)
In-Reply-To: <>

On Tue, Aug 10, 2021 at 03:59:20PM +0300, Pavel Skripkin wrote:
> Syzbot hit use-after-free in nf_tables_dump_sets. The problem was in
> missing lock protection for nft_ct_pcpu_template_refcnt.
> Before commit f102d66b335a ("netfilter: nf_tables: use dedicated
> mutex to guard transactions") all transactions were serialized by global
> mutex, but then global mutex was changed to local per netnamespace
> commit_mutex.
> This change causes use-after-free bug, when 2 netnamespaces concurently
> changing nft_ct_pcpu_template_refcnt without proper locking. Fix it by
> adding nft_ct_pcpu_mutex and protect all nft_ct_pcpu_template_refcnt
> changes with it.

Applied to nf.git, thanks

      parent reply	other threads:[~2021-08-11  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 12:55 [PATCH] netfiler: " Pavel Skripkin
2021-08-10 12:59 ` [PATCH v2] netfilter: " Pavel Skripkin
2021-08-10 13:22   ` Florian Westphal
2021-08-11  9:22   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811092201.GA23996@salvia \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] netfilter: protect nft_ct_pcpu_template_refcnt with mutex' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).