Netdev Archive on
help / color / mirror / Atom feed
From: Vladimir Oltean <>
To: DENG Qingfang <>
Cc: Sean Wang <>,
	Landen Chao <>,
	Andrew Lunn <>,
	Vivien Didelot <>,
	Florian Fainelli <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	Matthias Brugger <>,
	Philipp Zabel <>,
	Russell King <>,
	"moderated list:ARM/Mediatek SoC support" 
	"moderated list:ARM/Mediatek SoC support" 
	open list <>
Subject: Re: [PATCH net-next] net: dsa: mt7530: fix VLAN traffic leaks again
Date: Wed, 11 Aug 2021 13:01:22 +0300	[thread overview]
Message-ID: <20210811100122.hntia6od6qdc6dvd@skbuf> (raw)
In-Reply-To: <>

On Wed, Aug 11, 2021 at 05:50:43PM +0800, DENG Qingfang wrote:
> When a port leaves a VLAN-aware bridge, the current code does not clear
> other ports' matrix field bit. If the bridge is later set to VLAN-unaware
> mode, traffic in the bridge may leak to that port.
> Remove the VLAN filtering check in mt7530_port_bridge_leave.
> Fixes: 474a2ddaa192 ("net: dsa: mt7530: fix VLAN traffic leaks")
> Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
> Signed-off-by: DENG Qingfang <>
> ---

That hunk looked indeed very strange when I went over it with commit
'net: dsa: remove the "dsa_to_port in a loop" antipattern from drivers',
so I'm happy to see it go away.

Reviewed-by: Vladimir Oltean <>

  reply	other threads:[~2021-08-11 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  9:50 DENG Qingfang
2021-08-11 10:01 ` Vladimir Oltean [this message]
2021-08-12 10:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811100122.hntia6od6qdc6dvd@skbuf \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next] net: dsa: mt7530: fix VLAN traffic leaks again' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).