From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8928EC4320A for ; Thu, 12 Aug 2021 04:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B21060FBF for ; Thu, 12 Aug 2021 04:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234100AbhHLEuk (ORCPT ); Thu, 12 Aug 2021 00:50:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44143 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234067AbhHLEuj (ORCPT ); Thu, 12 Aug 2021 00:50:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628743814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3EdCh8jUcOhbmGjP/pel54QwoWirthHm42Spak8Fu+8=; b=XaRu5S0mpu7Qlk+W9j/KuwELL/6ObYIK16NS4JlqAUWYR+UUino+Tw1urqHZkl7H3BffvI v0BQHn8KOXGU7FA4YAneP6Tw3RsS38IGNulubA4qoNGjzzn6mi3RjT4fQyrdmusxLrP6vX 4N5og1whrAuOkXQsn4eiquFMlKV1Hmg= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-EQYUir8KNiOwzLcBDVBRoQ-1; Thu, 12 Aug 2021 00:50:09 -0400 X-MC-Unique: EQYUir8KNiOwzLcBDVBRoQ-1 Received: by mail-ej1-f72.google.com with SMTP id a19-20020a1709063e93b0290551ea218ea2so1379935ejj.5 for ; Wed, 11 Aug 2021 21:50:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3EdCh8jUcOhbmGjP/pel54QwoWirthHm42Spak8Fu+8=; b=jBGvFc1lXCdQZRsPD97wDdN7vW5e/ZsPDgZuVO1E9YyTrrFyfoPhFy1A/d7/LdKuc8 oo6nMPXGkzk8+1RSuAHPoAbvk/5ffzJpdN7WP4qEqrnVGI+ilSHHWgFWAVRBi0nYrE7j Vltc90ObP9wMc2Pwjy0i8joCFGOM9DWqMW/HjvxqaMBn1lJC/NOuXR0Ju2DHdH03+hgJ 8W8JGPzMUthopc1tu82xBqrV6/QXWLRyUubkOhLlSOz5pnrF7Sf61u0c4DKfIHgRBlZV dDen0Z5w6Ynpv3BkKYpQVIbYqDBqp30ehA5XhKbr29O1HgEgbHYptn8vcR9B7NlvkmN6 8kTQ== X-Gm-Message-State: AOAM53122f31/fNpHtalw04e8qlA2WSV/RTuMPi3Cbo4prAJjzyPocdt d3Eq020u7SFaRoYIPO4JjCObHdh6JyHItgi5DsX0IhY1SxwcVgpSkvg2IP6R7gwBL9lehLw2n+Q Fv+EMSc6n6CeH20eu X-Received: by 2002:a17:906:7209:: with SMTP id m9mr1547128ejk.387.1628743808135; Wed, 11 Aug 2021 21:50:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz91E0jQ/THuDZMxVBENUTarq0cDXA5MCRzrG+Zz2hon71s0/8E+SBP/0DQrOIwM4NFPdSj+w== X-Received: by 2002:a17:906:7209:: with SMTP id m9mr1547120ejk.387.1628743807976; Wed, 11 Aug 2021 21:50:07 -0700 (PDT) Received: from redhat.com ([2.55.129.96]) by smtp.gmail.com with ESMTPSA id t25sm544780edi.65.2021.08.11.21.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 21:50:07 -0700 (PDT) Date: Thu, 12 Aug 2021 00:50:03 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Jakub Kicinski , davem@davemloft.net, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ivan@prestigetransportation.com, xiangxia.m.yue@gmail.com, willemb@google.com, edumazet@google.com Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO Message-ID: <20210812004655-mutt-send-email-mst@kernel.org> References: <20210811081623.9832-1-jasowang@redhat.com> <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote: > > 在 2021/8/12 上午6:17, Jakub Kicinski 写道: > > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: > > > Try to fix this by using NETIF_F_GRO_HW instead so we're not > > > guaranteed to be re-segmented as original. > > This sentence may need rephrasing. > > > Right, actually, I meant: > > > Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the > packet could be re-segmented to the exact original packet stream. Since it's > really depends on the bakcend implementation. > > > > > > > Or we may want a new netdev > > > feature like RX_GSO since the guest offloads for virtio-net is > > > actually to receive GSO packet. > > > > > > Or we can try not advertise LRO is control guest offloads is not > > > enabled. This solves the warning but will still slow down the traffic. > > IMO gro-hw fits pretty well, patch looks good. > > > If the re-segmentation is not a issue. I will post a formal patch. > > Thanks It is but the point is even though spec did not require this we always allowed these configurations in the past so hopefully most of them are not broken and combine packets in the same way as GRO. Let's not break them all in an attempt to catch bad configs, and meanwhile amend the spec to recommend doing GW GRO. > > >