Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shai Malin <smalin@marvell.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<aelior@marvell.com>, <malin1024@gmail.com>
Subject: Re: [PATCH v2] qed: qed ll2 race condition fixes
Date: Fri, 13 Aug 2021 17:05:30 -0700 [thread overview]
Message-ID: <20210813170530.7a12984f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210812195313.7220-1-smalin@marvell.com>
On Thu, 12 Aug 2021 22:53:13 +0300 Shai Malin wrote:
> Avoiding qed ll2 race condition and NULL pointer dereference as part
> of the remove and recovery flows.
>
> Changes form V1:
> - Change (!p_rx->set_prod_addr).
> - qed_ll2.c checkpatch fixes.
>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Shai Malin <smalin@marvell.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_ll2.c | 38 +++++++++++++++++------
> 1 file changed, 29 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 02a4610d9330..9a9f0c516c0c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -106,7 +106,7 @@ static int qed_ll2_alloc_buffer(struct qed_dev *cdev,
> }
>
> static int qed_ll2_dealloc_buffer(struct qed_dev *cdev,
> - struct qed_ll2_buffer *buffer)
> + struct qed_ll2_buffer *buffer)
> {
> spin_lock_bh(&cdev->ll2->lock);
>
> @@ -670,11 +682,11 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn,
> p_pkt = list_first_entry(&p_rx->active_descq,
> struct qed_ll2_rx_packet, list_entry);
>
> - if ((iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_NEW_ISLE) ||
> - (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_RIGHT) ||
> - (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_LEFT) ||
> - (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_PEN) ||
> - (iscsi_ooo->ooo_opcode == TCP_EVENT_JOIN)) {
> + if (iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_NEW_ISLE ||
> + iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_RIGHT ||
> + iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_ISLE_LEFT ||
> + iscsi_ooo->ooo_opcode == TCP_EVENT_ADD_PEN ||
> + iscsi_ooo->ooo_opcode == TCP_EVENT_JOIN) {
> if (!p_pkt) {
> DP_NOTICE(p_hwfn,
> "LL2 OOO RX packet is not valid\n");
Sorry, I missed this before, please don't mix code clean up into
unrelated patches. Especially into fixes. Same goes for your other
patch (qed: Fix null-pointer dereference in qed_rdma_create_qp()).
next prev parent reply other threads:[~2021-08-14 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 19:53 Shai Malin
2021-08-14 0:05 ` Jakub Kicinski [this message]
2021-08-15 8:18 Shai Malin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813170530.7a12984f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=malin1024@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smalin@marvell.com \
--subject='Re: [PATCH v2] qed: qed ll2 race condition fixes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).