Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] bonding: improve nl error msg when device can't be enslaved because of IFF_MASTER
@ 2021-08-16 10:08 Antoine Tenart
2021-08-16 13:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Antoine Tenart @ 2021-08-16 10:08 UTC (permalink / raw)
To: davem, kuba; +Cc: Antoine Tenart, j.vosburgh, vfalico, andy, netdev
Use a more user friendly netlink error message when a device can't be
enslaved because it has IFF_MASTER, by not referring directly to a
kernel internal flag.
Signed-off-by: Antoine Tenart <atenart@kernel.org>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 04158a8368e4..b0966e733926 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1759,7 +1759,7 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
if (slave_dev->flags & IFF_MASTER &&
!netif_is_bond_master(slave_dev)) {
BOND_NL_ERR(bond_dev, extack,
- "Device with IFF_MASTER cannot be enslaved");
+ "Device type (master device) cannot be enslaved");
return -EPERM;
}
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] bonding: improve nl error msg when device can't be enslaved because of IFF_MASTER
2021-08-16 10:08 [PATCH net-next] bonding: improve nl error msg when device can't be enslaved because of IFF_MASTER Antoine Tenart
@ 2021-08-16 13:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-16 13:10 UTC (permalink / raw)
To: Antoine Tenart; +Cc: davem, kuba, j.vosburgh, vfalico, andy, netdev
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 16 Aug 2021 12:08:28 +0200 you wrote:
> Use a more user friendly netlink error message when a device can't be
> enslaved because it has IFF_MASTER, by not referring directly to a
> kernel internal flag.
>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] bonding: improve nl error msg when device can't be enslaved because of IFF_MASTER
https://git.kernel.org/netdev/net-next/c/1b3f78df6a80
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-16 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 10:08 [PATCH net-next] bonding: improve nl error msg when device can't be enslaved because of IFF_MASTER Antoine Tenart
2021-08-16 13:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).